Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SPARCNet and ContraWR #611

Merged
merged 19 commits into from
May 19, 2024

Conversation

bruAristimunha
Copy link
Collaborator

@bruAristimunha bruAristimunha commented May 15, 2024

In Biot's article, in addition to the BIOT model, the author centralizes codes from other models.

The list is:

  1. SPaRCNet,
  2. ContraWR,
  3. CNN-Transformer,
  4. FFCL and
  5. ST-Transformer (predecessor of EEG Conformer, which we already have implemented here).

In this PR, I am proposing to implement 1) SPaRCNet and 2) ContraWR.

  1. CNN-Transformer seemed very similar to ContraWR, I don't think it's worth implementing.
  2. The FFCL does not appear to be correctly implemented.

@bruAristimunha
Copy link
Collaborator Author

fyi @mccorsi

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 99.22481% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.20%. Comparing base (77b4f8b) to head (b1caba7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   86.93%   87.20%   +0.26%     
==========================================
  Files          65       67       +2     
  Lines        5796     5925     +129     
==========================================
+ Hits         5039     5167     +128     
- Misses        757      758       +1     

Copy link
Collaborator

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point it would be good to do a full evaluation of all these architectures on a some standard datasets

braindecode/models/sparcnet.py Outdated Show resolved Hide resolved
braindecode/models/sparcnet.py Show resolved Hide resolved
braindecode/models/sparcnet.py Outdated Show resolved Hide resolved
braindecode/models/sparcnet.py Outdated Show resolved Hide resolved
@bruAristimunha
Copy link
Collaborator Author

The green button is yours @agramfort

@agramfort agramfort merged commit 7c88b4c into braindecode:master May 19, 2024
20 checks passed
@bruAristimunha bruAristimunha deleted the models-from-biot branch May 20, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants