Infer shape of source space from target space

[kclamar]

Hi,

I'm wondering if it's possible to allow transformations of coordinates when the target space has a shape but the source space doesn't?

[vigji]

Hi @kclamar, thanks for the PR!
My concern there is that it can be dangerous to infer source from target in the eventuality one just forgot to define the source shape. Can you make a use case for this? In general, I was assuming one would always have the shape of both, but I am happy to discuss it with a use case at hand!
If we go for this option, I would at least make it not the default behavior - ie, add a kword argument infer_source_shape=False that needs to be passed for the behavior proposed in the PR

[kclamar]

Hi @vigji,

Thanks for the response! In my workflow I save the coordinates of points in the "sal" space and sometimes I need to convert the coordinates to the space of the mpin_zfish_1um atlas. When I initialize the source space for the conversion I need to calculate the shape of the atlas stack after transforming to the source space. I think it'd be convenient to have this new feature since the atlas space already contains the shape information. I also see why it could be dangerous, so I think that having a keyword argument for this feature and making it not the default behavior would be a good option.

[vigji]

Awesome!
This is good to go for me, would you mind just adding a little test for your addition in the tests module so that coverage is not decreased? It should be easy by looking at the rest of the tests in the module, but I can give more pointers if needed!

[kclamar]

I've added a test with axes flipping and reordering.

[vigji]

Awwwwwesome! Thank you very much @kclamar !

[vigji]

will release a new version with this