Skip to content

Commit

Permalink
fix allen mouse
Browse files Browse the repository at this point in the history
  • Loading branch information
@FedeClaudi
FedeClaudi committed Jun 2, 2020
1 parent 63ecaeb commit 4cdfe5a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion atlas_gen/atlas_scripts/allen_mouse_atlas.py
View file
Expand Up @@ -12,7 +12,7 @@
# Specify information about the atlas:
RES_UM = 25
VERSION = 2
ATLAS_NAME = f"allen_mouse"
ATLAS_NAME = f"allen_brain"
SPECIES = "Mus musculus"
ATLAS_LINK = "http://www.brain-map.org.com"
CITATION = "Wang et al 2020, https://doi.org/10.1016/j.cell.2020.04.007"
Expand Down

4 comments on commit 4cdfe5a

@vigji
Copy link
Member

@vigji vigji commented on 4cdfe5a Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be allen_mouse right?

@FedeClaudi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was getting confused yesterday, there was some inconsistency for the naming of the atlas between the different scripts, the name of the folder where the atlas is saved/downloded and the name in the bg_atlas.py class.
I think that when you download the atlas from GIN there's something there's a discrepancy between the atlas name and the folder name (some missing '_') but I didn't look into it, I only know it gave me a file not found error while looking for metadata.json. Would be good to ensure consistency.

Allen_mouse would be best.

@vigji
Copy link
Member

@vigji vigji commented on 4cdfe5a Jun 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have the fresh new atlas locally but did not uploaded to GIN yet.
I think in general we should do something like each atlas has a responsible person in charge who does all the bug fixing for that atlas, does this make sense?

@FedeClaudi
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

Please sign in to comment.