Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Refactor so THRESHOLD and SOMA_CENTRE_VALUE are defined in one place #387

Open
alessandrofelder opened this issue Feb 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@alessandrofelder
Copy link
Member

Is your feature request related to a problem? Please describe.
In cell candidate detection, we set aside two very high integer values (currently SOMA_CENTRE_VALUE as np.uint16.max-1 and THRESHOLD as np.uint16.max-2) to mark pixels as belonging to a cell after 3D and 2D filtering respectively.

This is a problem (see #383), so will switch to np.uint32.

Additionally though, we define this in several places

Describe the solution you'd like
These important labels should only be defined in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant