Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop on failure trigger on pre-commit #130

Closed
daniyals opened this issue Jul 20, 2022 · 0 comments
Closed

Stop on failure trigger on pre-commit #130

daniyals opened this issue Jul 20, 2022 · 0 comments

Comments

@daniyals
Copy link

daniyals commented Jul 20, 2022

I have a laravel/pint configured with pre-commit hook, and it says PASS on the output but the stop-on-failure is triggered and commit does not go through.

"hooks": {
            "config": {
                "stop-on-failure": ["pre-commit"]
            },
            "pre-commit": [
                "vendor/bin/pint"
            ],
            "commit-msg": "grep -q '[A-Z]+-[0-9]+.*' $1",
            "pre-push": [],
            "post-merge": ""
        }

Output:

............................................................................
  ............................................................................
  ............................................................................
  ............................................................................
  ............................................................................
  ............................................................................
  ............................................................................
  ............................................................................
  ......................................................................

  ──────────────────────────────────────────────────────────────────── Laravel  
    PASS   ......................................................... 678 files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant