Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shadow warnings #132

Closed
jcfr opened this issue Aug 1, 2014 · 8 comments
Closed

Fix shadow warnings #132

jcfr opened this issue Aug 1, 2014 · 8 comments
Assignees
@Chaircrusher

Comments

@jcfr
Copy link
Contributor

jcfr commented Aug 1, 2014

These warning has been found bulding BRAINSTool in Slicer using c93655a

In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:313:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.hxx: In instantiation of ‘void itk::BRAINSFitHelperTemplate<FixedImageType, MovingImageType>::Update() [with FixedImageType = itk::Image<float, 3u>; MovingImageType = itk::Image<float, 3u>]’:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:438:20:   required from ‘void itk::BRAINSFitHelper::RunRegistration() [with TLocalCostMetric = itk::MattesMutualInformationImageToImageMetricv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double>]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:320:43:   required from here
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.hxx:1177:74: warning: declaration of ‘BSplineTransformType’ shadows a global declaration [-Wshadow]
       typedef itk::BSplineTransform<double, SpaceDimension, SplineOrder> BSplineTransformType;
                                                                          ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.hxx:39:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:553,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:62,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.h:69:85: warning: shadowed declaration is here [-Wshadow]
                                         GenericTransformImageNS::SplineOrder>       BSplineTransformType;
                                                                                     ^
[...]

In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesEstimator.h:283:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesFromShiftBase.h:21,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesFromPhysicalShift.h:21,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Registration/RegistrationMethodsv4/include/itkImageRegistrationMethodv4.hxx:31,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Registration/RegistrationMethodsv4/include/itkImageRegistrationMethodv4.h:452,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:44,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:62,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesEstimator.hxx: In instantiation of ‘bool itk::RegistrationParameterScalesEstimator<TMetric>::IsBSplineTransform() [with TMetric = itk::MattesMutualInformationImageToImageMetricv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double>]’:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesFromShiftBase.hxx:98:5:   required from ‘void itk::RegistrationParameterScalesFromShiftBase<TMetric>::EstimateScales(itk::RegistrationParameterScalesFromShiftBase<TMetric>::ScalesType&) [with TMetric = itk::MattesMutualInformationImageToImageMetricv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double>; itk::RegistrationParameterScalesFromShiftBase<TMetric>::ScalesType = itk::OptimizerParameters<double>]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:629:1:   required from here
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesEstimator.hxx:173:62: warning: declaration of ‘CompositeTransformType’ shadows a global declaration [-Wshadow]
       typedef CompositeTransform<FloatType, MovingDimension> CompositeTransformType;
                                                              ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.hxx:39:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:553,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:62,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.h:71:62: warning: shadowed declaration is here [-Wshadow]
 typedef itk::CompositeTransform<double, 3>                   CompositeTransformType;
                                                              ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesEstimator.h:283:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesFromShiftBase.h:21,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesFromPhysicalShift.h:21,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Registration/RegistrationMethodsv4/include/itkImageRegistrationMethodv4.hxx:31,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Registration/RegistrationMethodsv4/include/itkImageRegistrationMethodv4.h:452,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:44,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:62,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesEstimator.hxx:192:61: warning: declaration of ‘CompositeTransformType’ shadows a global declaration [-Wshadow]
       typedef CompositeTransform<FloatType, FixedDimension> CompositeTransformType;
                                                             ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.hxx:39:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:553,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:62,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.h:71:62: warning: shadowed declaration is here [-Wshadow]
 typedef itk::CompositeTransform<double, 3>                   CompositeTransformType;
                                                              ^
[ 92%] Building CXX object Modules/Loadable/Volumes/Widgets/Testing/Cxx/CMakeFiles/qSlicerVolumesModuleWidgetsCxxTests.dir/qSlicerDTISliceDisplayWidgetTest2.cxx.o
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesEstimator.h:283:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesFromShiftBase.h:21,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesFromPhysicalShift.h:21,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Registration/RegistrationMethodsv4/include/itkImageRegistrationMethodv4.hxx:31,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Registration/RegistrationMethodsv4/include/itkImageRegistrationMethodv4.h:452,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:44,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:62,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesEstimator.hxx: In instantiation of ‘bool itk::RegistrationParameterScalesEstimator<TMetric>::IsBSplineTransform() [with TMetric = itk::ImageToImageMetricv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double, itk::DefaultImageToImageMetricTraitsv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double> >]’:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesFromShiftBase.hxx:98:5:   required from ‘void itk::RegistrationParameterScalesFromShiftBase<TMetric>::EstimateScales(itk::RegistrationParameterScalesFromShiftBase<TMetric>::ScalesType&) [with TMetric = itk::ImageToImageMetricv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double, itk::DefaultImageToImageMetricTraitsv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double> >; itk::RegistrationParameterScalesFromShiftBase<TMetric>::ScalesType = itk::OptimizerParameters<double>]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:629:1:   required from here
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesEstimator.hxx:173:62: warning: declaration of ‘CompositeTransformType’ shadows a global declaration [-Wshadow]
       typedef CompositeTransform<FloatType, MovingDimension> CompositeTransformType;
                                                              ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.hxx:39:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:553,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:62,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.h:71:62: warning: shadowed declaration is here [-Wshadow]
 typedef itk::CompositeTransform<double, 3>                   CompositeTransformType;
                                                              ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesEstimator.h:283:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesFromShiftBase.h:21,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesFromPhysicalShift.h:21,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Registration/RegistrationMethodsv4/include/itkImageRegistrationMethodv4.hxx:31,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Registration/RegistrationMethodsv4/include/itkImageRegistrationMethodv4.h:452,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:44,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:62,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/ITKv4/Modules/Numerics/Optimizersv4/include/itkRegistrationParameterScalesEstimator.hxx:192:61: warning: declaration of ‘CompositeTransformType’ shadows a global declaration [-Wshadow]
       typedef CompositeTransform<FloatType, FixedDimension> CompositeTransformType;
                                                             ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.hxx:39:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:553,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:62,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.h:71:62: warning: shadowed declaration is here [-Wshadow]
 typedef itk::CompositeTransform<double, 3>                   CompositeTransformType;
@hjmjohnson
Copy link
Member

@aghayoor Please try to fix these warnings. We don't have a compiler that issues these warnings, so you will have to to it a bit blind.

Hans

@jcfr
Copy link
Contributor Author

jcfr commented Aug 1, 2014

Which compiler are you using ?

I am using the one coming with Ubuntu 13.10 ...

$ g++ --version
g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1

On Fri, Aug 1, 2014 at 12:26 PM, hjmjohnson notifications@github.com
wrote:

@aghayoor https://github.com/aghayoor Please try to fix these warnings.
We don't have a compiler that issues these warnings, so you will have to to
it a bit blind.

Hans

—
Reply to this email directly or view it on GitHub
#132 (comment)
.

+1 919 869 8849

@Chaircrusher
Copy link

We’re standardized on Red Hat Enterprise Linux for all our real servers/workstations. I’ll investigate getting a VM running with ubuntu 13.10… 4.8.1 isn’t quite bleeding edge. I’d maybe wait on 4.9 except for experimenting:
http://www.phoronix.com/scan.php?page=news_item&px=MTc1MDQ

From: Jean-Christophe Fillion-Robin <notifications@github.commailto:notifications@github.com>
Reply-To: BRAINSia/BRAINSTools <reply@reply.github.commailto:reply@reply.github.com>
Date: Friday, August 1, 2014 at 11:46 AM
To: BRAINSia/BRAINSTools <BRAINSTools@noreply.github.commailto:BRAINSTools@noreply.github.com>
Subject: Re: [BRAINSTools] Fix shadow warnings (#132)

Which compiler are you using ?

I am using the one coming with Ubuntu 13.10 ...

$ g++ --version
g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1

On Fri, Aug 1, 2014 at 12:26 PM, hjmjohnson <notifications@github.commailto:notifications@github.com>
wrote:

@aghayoor https://github.com/aghayoor Please try to fix these warnings.
We don't have a compiler that issues these warnings, so you will have to to
it a bit blind.

Hans

—
Reply to this email directly or view it on GitHub
#132 (comment)
.

+1 919 869 8849

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/132#issuecomment-50907262.

Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you.

@hjmjohnson
Copy link
Member

These will only show up in 4.8 gcc. They turned this wanting back off I. 4.9 I think. ITK had similar issues.

Sent from my iPhone

On Aug 1, 2014, at 11:46 AM, Jean-Christophe Fillion-Robin notifications@github.com wrote:

Which compiler are you using ?

I am using the one coming with Ubuntu 13.10 ...

$ g++ --version 
g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1

On Fri, Aug 1, 2014 at 12:26 PM, hjmjohnson notifications@github.com
wrote:

@aghayoor https://github.com/aghayoor Please try to fix these warnings.
We don't have a compiler that issues these warnings, so you will have to to
it a bit blind.

Hans

—
Reply to this email directly or view it on GitHub
#132 (comment)
.

+1 919 869 8849
—
Reply to this email directly or view it on GitHub.

@jcfr
Copy link
Contributor Author

jcfr commented Aug 1, 2014

I think you are talking about "Wunused-local-*typedefs" * flag. And
they all have been fixed in ITK/Slicer .. this allows to keep you code
readable.

Regarding the shadow, the warning in 4.8 are most useful .. if I understand
well they now report what could a real issue:

From https://gcc.gnu.org/gcc-4.8/changes.html:

  • The option -Wshadow no longer warns if a declaration shadows a
    function declaration, unless the former declares a function or pointer to
    function, because this is a common and valid case in real-world code
    https://lkml.org/lkml/2006/11/28/239.

On Fri, Aug 1, 2014 at 3:10 PM, hjmjohnson notifications@github.com wrote:

These will only show up in 4.8 gcc. They turned this wanting back off I.
4.9 I think. ITK had similar issues.

Sent from my iPhone

On Aug 1, 2014, at 11:46 AM, Jean-Christophe Fillion-Robin <
notifications@github.com> wrote:

Which compiler are you using ?

I am using the one coming with Ubuntu 13.10 ...

$ g++ --version
g++ (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1

On Fri, Aug 1, 2014 at 12:26 PM, hjmjohnson notifications@github.com
wrote:

@aghayoor https://github.com/aghayoor Please try to fix these
warnings.
We don't have a compiler that issues these warnings, so you will have
to to
it a bit blind.

Hans

—
Reply to this email directly or view it on GitHub
<
https://github.com/BRAINSia/BRAINSTools/issues/132#issuecomment-50904829>
.

+1 919 869 8849
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
#132 (comment)
.

+1 919 869 8849

@hjmjohnson
Copy link
Member

Kent Please take care of this issue when you return on Thursday.

Hans

@Chaircrusher
Copy link

Fixed in f00678a

@jcfr
Copy link
Contributor Author

jcfr commented Sep 15, 2014

@Chaircrusher Thanks for working on this.

There are few more:

In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.h:196:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.hxx:39,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:559,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:63,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.hxx: In instantiation of ‘typename OutputImageType::Pointer GenericTransformImage(const InputImageType*, const itk::ImageBase<TImage:: ImageDimension>*, itk::Transform<double, 3u, 3u>::Pointer, typename InputImageType::PixelType, const string&, bool) [with InputImageType = itk::Image<float, 3u>; OutputImageType = itk::Image<float, 3u>; DisplacementImageType = itk::Image<itk::Vector<float, 3u>, 3u>; typename OutputImageType::Pointer = itk::SmartPointer<itk::Image<float, 3u> >; itk::Transform<double, 3u, 3u>::Pointer = itk::SmartPointer<itk::Transform<double, 3u, 3u> >; typename InputImageType::PixelType = float; std::string = std::basic_string<char>]’:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.hxx:1386:84:   required from ‘void itk::BRAINSFitHelperTemplate<FixedImageType, MovingImageType>::Update() [with FixedImageType = itk::Image<float, 3u>; MovingImageType = itk::Image<float, 3u>]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:446:20:   required from ‘void itk::BRAINSFitHelper::RunRegistration() [with TLocalCostMetric = itk::MattesMutualInformationImageToImageMetricv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double, itk::DefaultImageToImageMetricTraitsv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double> >]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:322:43:   required from here
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.hxx:343:54: warning: declaration of ‘VersorRigid3DTransformType’ shadows a global declaration [-Wshadow]
       typedef itk::VersorRigid3DTransform<double>    VersorRigid3DTransformType;
                                                      ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:20:0:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitUtils.h:47:58: warning: shadowed declaration is here [-Wshadow]
 typedef itk::VersorRigid3DTransform<double>              VersorRigid3DTransformType;
                                                          ^
[  9%] Built target CreateDICOMSeries
[  9%] Built target CLIROITestLib
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.h:196:0,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.hxx:39,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/genericRegistrationHelper.h:559,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.h:63,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:43,
                 from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:21:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.hxx: In instantiation of ‘typename OutputImageType::Pointer GenericTransformImage(const InputImageType*, const itk::ImageBase<TImage:: ImageDimension>*, itk::Transform<double, 3u, 3u>::Pointer, typename InputImageType::PixelType, const string&, bool) [with InputImageType = itk::Image<unsigned char, 3u>; OutputImageType = itk::Image<unsigned char, 3u>; DisplacementImageType = itk::Image<itk::Vector<float, 3u>, 3u>; typename OutputImageType::Pointer = itk::SmartPointer<itk::Image<unsigned char, 3u> >; itk::Transform<double, 3u, 3u>::Pointer = itk::SmartPointer<itk::Transform<double, 3u, 3u> >; typename InputImageType::PixelType = unsigned char; std::string = std::basic_string<char>]’:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelperTemplate.hxx:1406:88:   required from ‘void itk::BRAINSFitHelperTemplate<FixedImageType, MovingImageType>::Update() [with FixedImageType = itk::Image<float, 3u>; MovingImageType = itk::Image<float, 3u>]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.h:446:20:   required from ‘void itk::BRAINSFitHelper::RunRegistration() [with TLocalCostMetric = itk::MattesMutualInformationImageToImageMetricv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double, itk::DefaultImageToImageMetricTraitsv4<itk::Image<float, 3u>, itk::Image<float, 3u>, itk::Image<float, 3u>, double> >]’
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:322:43:   required from here
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/GenericTransformImage.hxx:343:54: warning: declaration of ‘VersorRigid3DTransformType’ shadows a global declaration [-Wshadow]
       typedef itk::VersorRigid3DTransform<double>    VersorRigid3DTransformType;
                                                      ^
In file included from /home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitHelper.cxx:20:0:
/home/jchris/Projects/Slicer-2-SuperBuild-Debug/BRAINSTools/BRAINSCommonLib/BRAINSFitUtils.h:47:58: warning: shadowed declaration is here [-Wshadow]
 typedef itk::VersorRigid3DTransform<double>              VersorRigid3DTransformType;

@jcfr jcfr mentioned this issue Sep 15, 2014
Closed
@hjmjohnson hjmjohnson mentioned this issue Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chaircrusher Chaircrusher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcfr @hjmjohnson @Chaircrusher