-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BRAINS without V3 compatibility #152
Comments
I responded to a request to take out ITKv3 compatibility last week or the week before. Is Bradley using a current version of BRAINSTools? I'll take a look tomorrow. From: hjmjohnson [notifications@github.com] -----Original Message----- Kent, Please take care of this ASAP this week. Hans -----Original Message----- Hans, I am only getting one compilation error when compiling BRAINS is Slicer3d I am getting a funny error here: because there is no New method available, for the Ridgid3DTransform I am not sure if other issues related to this transform in BRANSTOOLS and Thanks, — Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged. If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited. Please reply to the sender that you have received the message in error, then delete it. Thank you. |
The problem is that without being pure virtual, Rigid3DTransform and Rigid2D Transform are never supposed to be instantiated. My solution is to replace Rigid3DTransform with VersorTransform, and Rigid2DTransform with CenteredRigid2DTransform. Those two new transform types should work in this context. If you think different let me know. |
Seems like a good solution. Hans From: Kent Williams notifications@github.com The problem is that without being pure virtual, Rigid3DTransform and Rigid2D Those two new transform types should work in this context. If you think ‹ |
Fixed in 8db648a31e095cc2a4d291c23313938ce70c92ec |
-----Original Message-----
From: , Hans Johnson hans-johnson@uiowa.edu
Date: Wednesday, September 24, 2014 at 9:39 AM
To: Bradley Lowekamp blowekamp@mail.nih.gov
Cc: Kent Williams nkwmailinglists@gmail.com
Subject: Re: BRAINS without V3 compatibility
Kent,
Please take care of this ASAP this week.
Hans
-----Original Message-----
From: Bradley Lowekamp blowekamp@mail.nih.gov
Date: Wednesday, September 24, 2014 at 9:37 AM
To: Hans Johnson hans-johnson@uiowa.edu
Cc: Kent Williams nkwmailinglists@gmail.com
Subject: BRAINS without V3 compatibility
Hans,
I am only getting one compilation error when compiling BRAINS is Slicer3d
with out V3 compatibility and 64-bit IDS.
I am getting a funny error here:
https://github.com/BRAINSia/BRAINSTools/blob/master/BRAINSStripRotation/BRA
INSStripRotation.cxx#L31
because there is no New method available, for the Ridgid3DTransform
without V3 Compatibility:
https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Core/T
ransform/include/itkRigid3DTransform.h#L68-L71
I am not sure if other issues related to this transform in BRANSTOOLS and
the v3 compatibility.
Thanks,
Brad
The text was updated successfully, but these errors were encountered: