Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ITKDeprecated (and ITKV3Compatibility from list of ITK components #154

Closed
jcfr opened this issue Sep 25, 2014 · 5 comments
Closed

Remove ITKDeprecated (and ITKV3Compatibility from list of ITK components #154

jcfr opened this issue Sep 25, 2014 · 5 comments
Assignees
@aghayoor
Labels
S2:Ready for Discussion Group input needed to scope solutions (pilot testing)

Comments

@jcfr
Copy link
Contributor

jcfr commented Sep 25, 2014

To follow up with 13969f3, I would suggest to remove the corresponding ITK components.

See https://github.com/BRAINSia/BRAINSTools/search?utf8=%E2%9C%93&q=ITKDeprecated
and https://github.com/BRAINSia/BRAINSTools/search?utf8=%E2%9C%93&q=ITKV3Compatibility+
@jcfr
Copy link
Contributor Author

jcfr commented Sep 25, 2014

Similarly, the option to build ITK should be disabled. See

BRAINSTools/SuperBuild/External_ITKv4.cmake

Line 58 in f29beb2

-DITKV3_COMPATIBILITY:BOOL=ON

@jcfr
Copy link
Contributor Author

jcfr commented Sep 25, 2014

And may be ITK_LEGACY_REMOVE could also be turned ON that is an other topic.

@jcfr jcfr changed the title Remove ITKDeprecated (and ITKV3Compatibility from list of ITK component Remove ITKDeprecated (and ITKV3Compatibility from list of ITK components Sep 25, 2014
@hjmjohnson
Copy link
Member

I would love to get to the point in BRAINSTools where ITK_LEGACY_REMOVE:BOOL=ON!

@dmwelch dmwelch added the S2:Ready for Discussion Group input needed to scope solutions (pilot testing) label Sep 25, 2014
jcfr added a commit to Slicer/SlicerGitSVNArchive that referenced this issue Sep 27, 2014
@jcfr
COMP: Update BRAINSTools to fix build issue related to ITKDeprecated.
f70d076 
This commit is a follow-up of r23729 where BRAINSTools hasn't been updated
by mistake.

The update of BRAINSTools now includes the following commit:

// ----------------
Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Date:   Thu Sep 25 10:52:17 2014 -0400

    COMP: Remove ITKDeprecated from the list of ITK components.

    This commit is a follow-up of BRAINSia/BRAINSTools@13969f3

    An issue has been reported upstream, see BRAINSia/BRAINSTools#154
// ----------------

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23733 3bd1e089-480b-0410-8dfb-8563597acbee
jcfr added a commit to Slicer/BRAINSTools that referenced this issue Sep 27, 2014
@jcfr
COMP: Remove ITKDeprecated from the list of ITK components.
b82c7c8 
This commit is a follow-up of BRAINSia/BRAINSTools@13969f3

An issue has been reported upstream, see BRAINSia#154
@hjmjohnson hjmjohnson assigned aghayoor and unassigned Chaircrusher Dec 4, 2014
@hjmjohnson
Copy link
Member

This is still a work in progress. We are getting closer, but it requires changing DTIPrep and some other packages that depend on BRAINSTools.

@hjmjohnson hjmjohnson reopened this Dec 4, 2014
@hjmjohnson
Copy link
Member

This was completed during NAMIC project week

@hjmjohnson hjmjohnson mentioned this issue Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aghayoor aghayoor

Labels
S2:Ready for Discussion Group input needed to scope solutions (pilot testing)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jcfr @hjmjohnson @Chaircrusher @aghayoor @dmwelch