Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIRSTORM: Move to the plugin manager? #388

Closed
ftadel opened this issue Mar 13, 2021 · 4 comments
Closed

NIRSTORM: Move to the plugin manager? #388

ftadel opened this issue Mar 13, 2021 · 4 comments

Comments

@ftadel
Copy link
Member

ftadel commented Mar 13, 2021

@multifunkim @thomas-vincent @Edouard2laire

I added a new solution for managing the packages downloaded by Brainstorm:

It would be great if we could also move NIRSTORM to this framework, in order to have everything managed in a centralized way. This will also allow to have automated builds including all the dependencies (to keep on having NIRSTORM included in the compiled distribution of Brainstorm).

Who could help me with this task?
Maybe we could organize a short meeting to plan these changes?

@ftadel
Copy link
Member Author

ftadel commented Apr 27, 2021

I've just recompiled Brainstorm with the updated BrainEntropy and Nirstorm code.
Nirstorm should now work with both with the Matlab and the compiled distributions of Brainstorm.
Please test it and confirm that we can close this issue.

@ftadel
Copy link
Member Author

ftadel commented Sep 2, 2021

At this moment, Nirstorm is still excluded from the compiled version of Brainstorm.
It will be the case until this issue gets resolved: Nirstorm/nirstorm#155

Let me know when I should try include to recompile Brainstorm with Nirstorm.

@Edouard2laire
Copy link
Contributor

Edouard2laire commented Sep 2, 2021

Yes, i am still working on making the replacement process for the problematic ones. I should be able to merge them soon with the main branch of Nirstorm. I will let you know when its done :)

For OM: Edouard2laire/nirstorm@7e8d491
For Fluences: Nirstorm/nirstorm#170

@ftadel
Copy link
Member Author

ftadel commented Sep 21, 2021

Nirstorm repo issues were closed: Nirstorm/nirstorm#155

Nirstorm is restored as a compiled plugin: 0428eb6

@ftadel ftadel closed this as completed Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants