-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plugin] Move plugin definition to external Json file #574
Comments
Yes, this sounds like a very interesting idea! |
ok. I will work on it this weekend :) |
I'm looking a bit deeper into this idea and I'm not sure that the basic Brainstorm plugins currently defined in
For user plugins, it makes much more sense. And it could even be more modular than a single user_plugin.json file. I was thinking about maybe parsing all the .json files in the .brainstorm/plugin folder, for user plugins definition. I realize what I wrote is a bit messy, I haven't thought much about it, but wanted to share quickly these ideas before you spend too much time with the implementation. |
Few months ago, we revamped the bst-users repo, it may be helpful for these user plugins.
Does it make some sense? |
@Edouard2laire Maybe you could push there one of your (future) user plugins, as an example? |
Hello,
Recently, I was thinking about the possibility for the users to have additional plugin that are not officially integrated to brainstorm (typically code that are in .brainstorm/process). For example, I have a lot of code related to nirs project that I sometime needs to share with colleague and currently it makes it hard to track version of the scripts. With a plugin system, I could make sure all the script are always up-to-date between me and my colleagues and between my different computers :)
For the main plugin, this would allow some user to change the version of the external-software they want to use more easily.
To do that I was thinking to move the definition of the plugin to two files: but_plugin.json in the main brainstorm folder. and allows users to create a user_plugin.json in .brainstorm folder to specify user-specific
https://github.com/brainstorm-tools/brainstorm3/blob/master/toolbox/core/bst_plugin.m#L128-L599 would then be only reading of the json files.
Here is a proof of concept of how the file would looks like
Let me know if you think that is a good idea. I can start working on a PR then.
Edouard
The text was updated successfully, but these errors were encountered: