Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusual behaviour w/ Horse, Donkey, Mule and Ravager mounting #60

Closed
Darigsey opened this issue Apr 22, 2020 · 7 comments · Fixed by #114
Closed

Unusual behaviour w/ Horse, Donkey, Mule and Ravager mounting #60

Darigsey opened this issue Apr 22, 2020 · 7 comments · Fixed by #114

Comments

@Darigsey
Copy link

the saddles don't go on the horses and There are mistakes when riding all types of horse and when you dismount it runs wild

I use:paper-206.jar
and: SimplePets Build #28 (21.04.2020 11:42:13)

and sorry for my bad english

@Thatsmusic99
Copy link
Collaborator

Both problems are currently known of with unknown solutions. The majority of this seems to be client-side which is why you dismount in strange places (another player would think you're riding the horse fine, see this video for reference).

@iLemon
Copy link

iLemon commented May 29, 2020

I have players reporting this issue too.

@Thatsmusic99 Thatsmusic99 pinned this issue Jun 3, 2020
@Thatsmusic99 Thatsmusic99 changed the title problems with Horse Unusual behaviour w/ Horse, Donkey, Mule and Ravager mounting Jun 3, 2020
@Thatsmusic99
Copy link
Collaborator

Renamed to better fit its issue and also pinned.

  • The issue currently affects horses, donkeys, mules and ravagers (any more please mention them)
  • It seems present in the majority of versions
  • The problem appears to be prevalent on the client's end; see the video I posted in an earlier comment.
  • Players are teleported in unusual places because the server thinks that's where the player is; when a player sends a signal to the server to dismount, they are sent to where the server believes they should be.
  • There is no known fix to this as of right now and will be an issue inspected deeply once SP's library is changed.

@Thatsmusic99
Copy link
Collaborator

Confirmed partially fixed in the experimental builds (of which are not currently recommended), for some stupid reason all the mounts needed saddles to function properly.

However, because the ravager does not use saddles, it is not known what causes the problems with it.

@frengor
Copy link

frengor commented Aug 29, 2020

I think this is due to internal minecraft changes. The method a(float, float, float) in Entity class changed to e(Vec3D). If you check EntityPet class, you'll see the 3 floats are currently took from the Vec3D, like if they were group up into a single object, but it isn't. The Vec3D contains coordinates. Thus, the current method makes every pet moving diagonally.

@Thatsmusic99
Copy link
Collaborator

It does not make all pets move diagonally, that was an issue fixed in the Jenkins build and is an entirely different issue. This bug only affects the ravager as of currently.

@brainsynder-Dev
Copy link
Owner

brainsynder-Dev commented Sep 1, 2020

Here is an update for this issue...

I have it at a point where riding horse type pets does not break (unless you spam jump... then it breaks BIG time)

The Ravager is broken even more tho...... (does not move at all, and no idea why yet xD )

@Thatsmusic99 Thatsmusic99 linked a pull request Jul 5, 2021 that will close this issue
@brainsynder-Dev brainsynder-Dev unpinned this issue Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants