Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4.0-rc1 build fails at BTDropInViewController.m:306 #54

Closed
ebfikus opened this issue Oct 8, 2014 · 2 comments
Closed

3.4.0-rc1 build fails at BTDropInViewController.m:306 #54

ebfikus opened this issue Oct 8, 2014 · 2 comments
Assignees

Comments

@ebfikus
Copy link

ebfikus commented Oct 8, 2014

I'm seeing this build error:

/Braintree/Braintree/Drop-In/Braintree-Drop-In/BTDropInViewController.m:306:36: error: incompatible pointer to integer conversion assigning to 'BOOL' (aka 'signed char') from 'NSNumber *' [-Werror,-Wint-conversion]
            request.shouldValidate = @YES;
                                   ^ ~~~~

Looks like shouldValidate is defined as a BOOL, not an NSNumber.

@mickeyreiss
Copy link
Contributor

Good find. I believe we may have this fixed internally already and will release a fix shortly.

@mickeyreiss
Copy link
Contributor

@ebfikus I just pushed a fix on master (ec9c3b0#diff-2).

You can expect to see version 3.4.0-rc2 later today, which will include this fix.

Thanks for letting us know! 🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants