Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pycurl #15

Closed
wants to merge 6 commits into from
Closed

Remove pycurl #15

wants to merge 6 commits into from

Conversation

paltman
Copy link

@paltman paltman commented Mar 16, 2011

looked like pycurl was only being used to validate the SSL cert which can be done with a simple backport from 3.0, which I included in this path.

by removing pycurl as a dependency it makes the library much more accessible especially in cases where the target deploy can't build pycurl as it depends on the curl development headers to be able to compile which are not always available on different hosts.

thanks,
Patrick Altman
Eldarion, Inc.

@braintreeps
Copy link
Contributor

This looks awesome, Patrick. We'll pull it down and check it out. Thanks for sharing this with us; we'll keep you posted as we look into pulling it in.

@paltman
Copy link
Author

paltman commented Mar 16, 2011

sure thing. let me know if there is anything i can do to help get this integrated in.

@paltman
Copy link
Author

paltman commented Mar 21, 2011

Any updates on this?

For the time being, I can create my own package on my own dist server, but would prefer to continue using the canonical version. Please let me know if there is anything I can do to expedite things.

@braintreeps
Copy link
Contributor

Sorry this has been taking a while. The problem we're dealing with is that python 2.5 doesn't have native support for SSL. So we are evaluating what we want to do about maintaining support for python 2.5 and Google App Engine.

We are planning to update this in our next python client library release. Thanks again for the patch, and we'll keep you updated as we figure things out.

@paltman
Copy link
Author

paltman commented Mar 30, 2011

I understand, for now I will create a private package for my needs (my host doesn't have the curl libraries installed) and will look forward to upgrading when I can.

@paltman
Copy link
Author

paltman commented Jun 6, 2011

Curious is if there has been any update on this?

@benmills
Copy link

benmills commented Jun 6, 2011

We've been looking into this pull request, unfortunately there have been a few other features that have taken a higher priority. We do want to get rid of our pycurl dependency soon but right now we can't give a time frame for when we will be able to get this in.

The main problem we are dealing with is trying to support python 2.5, if you have any ideas on how to do that easily let us know otherwise we will continue to explore ways to maintain backwards compatibility.

@clamprecht
Copy link

bump - any update? thx

@benmills
Copy link

benmills commented Feb 7, 2012

We've spent more time working through this issue but still are running into issues supporting python 2.5. We have a few ideas internally that we're going to explore to remove the dependency for versions of python greater than 2.5. At this time I can't give you a time line on when we will be able to release a version without pycurl as a dependency.

@braintreeps
Copy link
Contributor

The next version of the python library that we release will remove pycurl as a dependency for any version of Python greater than or equal to 2.6 and replace it with a dependency on requests (since requests supports ssl verification but httplib does not). Python 2.5 will continue to use pycurl.

@clamprecht
Copy link

Thanks braintreeps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants