Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derivative motion variable (M2) has wrong formula? #1

Open
jcwren opened this issue May 22, 2018 · 1 comment
Open

Derivative motion variable (M2) has wrong formula? #1

jcwren opened this issue May 22, 2018 · 1 comment

Comments

@jcwren
Copy link

jcwren commented May 22, 2018

I was looking at the output of your code vs some other code, and noticed that compared to the original G3RUH sources, you apply a different formula to the M2 variable than he does. I'm curious if you corrected an error in his code, or perhaps overlooked what he had done, or perhaps something obvious is eluding me.

In line 241, you have the following code: M2 = RADIANS(getdouble(l1, 33, 43)) ;

However, in G3RUH's code, at line 1370, he uses M2 = M2*2*PI

G3RUH's original code is at http://www.amsat.org/articles/g3ruh/111.html

Another issue that I found while in there is where a float is used instead of a double. Changing it to a double improves the accuracy.

@dl9sec
Copy link

dl9sec commented May 11, 2019

I came across the same issue.
Going through the code, because the prediction delivers results, which are not the same as my gpredict delivers...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants