Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 dependency #17

Closed
michield opened this issue Oct 18, 2022 · 3 comments · Fixed by phpList/phplist3#897
Closed

PHP 8.1 dependency #17

michield opened this issue Oct 18, 2022 · 3 comments · Fixed by phpList/phplist3#897

Comments

@michield
Copy link

The action on 8.1 fails https://github.com/phpList/phplist3/actions/runs/3276311183/jobs/5392220257

It's this error.

Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Your lock file does not contain a compatible set of packages. Please run composer update.

  Problem 1
    - pelago/emogrifier is locked to version v5.0.1 and an update of this package was not requested.
    - pelago/emogrifier v5.0.1 requires php ~7.1.0 || ~7.2.0 || ~7.3.0 || ~7.4.0 || ~8.0.0 -> your php version (8.1.0) does not satisfy that requirement.
  Problem 2
    - pelago/emogrifier v5.0.1 requires php ~7.1.0 || ~7.2.0 || ~7.3.0 || ~7.4.0 || ~8.0.0 -> your php version (8.1.0) does not satisfy that requirement.
    - bramley/phplist-plugin-common dev-master requires pelago/emogrifier ^5.0.1 -> satisfiable by pelago/emogrifier[v5.0.1].
    - bramley/phplist-plugin-common is locked to version dev-master and an update of this package was not requested.

@bramley
Copy link
Owner

bramley commented Oct 18, 2022

I suppose the solution is to upgrade to the latest version of emogrifier 6.0.0 whose composer.json has

    "php": "~7.3.0 || ~7.4.0 || ~8.0.0 || ~8.1.0 || ~8.2.0",

That will need some testing so I won't be able to complete that until later on tomorrow.

@bramley
Copy link
Owner

bramley commented Oct 19, 2022

I have now updated Common plugin to use version 6.0.0 of emogrifier. I think that I will need to re-do the pull request for dependencies so that the lock file reflects the new state.

@michield
Copy link
Author

michield commented Jan 8, 2023

all done

@michield michield closed this as completed Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants