Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "range" to "range_" to allow plsql to be generated #4

Open
tgulacsi opened this issue Dec 12, 2017 · 1 comment
Open

Rename "range" to "range_" to allow plsql to be generated #4

tgulacsi opened this issue Dec 12, 2017 · 1 comment

Comments

@tgulacsi
Copy link

diff --git a/Makefile b/Makefile
index c736ddb..bce3572 100644
--- a/Makefile
+++ b/Makefile
@@ -64,7 +64,7 @@ grammars-v4:
 # and creates a slightly different set of named files. This makes it
 # difficult to have one file. This is the best hack that keeps Make
 # working correctly.
-BUILD=sh -c '\
+BUILD=bash -c '\
        basedir=$$PWD; \
        errors=$$0/$$(basename $$1).log; \
        mkdir -p $$0; \
@@ -1029,7 +1029,9 @@ plsql plsql/plsql_test.go: plsql/plsqlparser_base_listener.go plsql/plsqlparser_
 plsql/doc.go: plsql/plsql_test.go

 %/plsqlparser_base_listener.go %/plsqlparser_listener.go %/plsql_parser.go: grammars-v4/plsql/PlSqlParser.g4 plsql/plsql_lexer.go
-       ${BUILD} plsql grammars-v4/plsql/PlSqlParser.g4 plsql/plsqlparser_base_listener.go plsql/plsqlparser_listener.go plsql/plsql_parser.go
+       mkdir -p grammars-v4/plsql/mod
+       sed -e 's/range/range_/g' grammars-v4/plsql/PlSqlParser.g4 >grammars-v4/plsql/mod/PlSqlParser.g4
+       ${BUILD} plsql grammars-v4/plsql/mod/PlSqlParser.g4 plsql/plsqlparser_base_listener.go plsql/plsqlparser_listener.go plsql/plsql_parser.go

 %/plsql_lexer.go: grammars-v4/plsql/PlSqlLexer.g4
        ${BUILD} plsql grammars-v4/plsql/PlSqlLexer.g4 plsql/plsql_lexer.go
@bramp
Copy link
Owner

bramp commented Dec 13, 2017

Very awesome, but the Makefile is generated by makemake.go. So your changes would be undone.

Instead, what I would accept is some change to the makefile generation to accomplish this in an generic way. For example, having a directory of patch files, that would be applied before trying to compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants