Uppercase friendly name

[ThomDietrich]

Hey! I finally got around testing this integration and my first super minor question is whether the generated default entity friendly name could be changed to upper case

It's probably as easy as changing this line:

homeassistant-powercalc/custom_components/powercalc/sensor.py

Line 105 in 36d6342

NAME_FORMAT = "{} power"

Thanks!

[bramstroker]

Hi, good to hear. Yes changing that line should fix it.
You can create a PR if you want.

[CM000n]

I've noticed this kind of representation as well, but wasn't sure if a change makes sense. Not that it's just our German habit to capitalize proper names and nouns. 😉 But since @bramstroker probably sees it similarly, I have made a small PR to it

[ThomDietrich]

@CM000n Thanks!

That's a good call. My experience tells me that most integrations capitalize their friendly names. I've just looked at my home setup and there is only one integration that has lowercase entity names (however it mixes in some uppercase names, so let's not look at this one for guidance 😉) I don't think there is a formal rule for this.

[bramstroker]

I don't have a hard preference for one or the other. I think it's more a german thing to do it. I'm looking for formal rules, but not sure what to search for.
Power is a common noun in the English language and should not be capitalized as far as I'm concerned. Only when it is used in the beginning of the sentence.
In my case it would look ugly because I only write the first letter of my entity name capitalized (Spots keuken = Spots kitchen in English), which will become "Spots kitchen Power".

[ThomDietrich]

Generally my decision would be in favor of how most prominent integrations do it. Looking at different other integrations, I am seeing a mix but also a couple of integrations which work with lowercase. I would be okay to accept that and discard the request here ;)

[bramstroker]

@ThomDietrich I prefer to keep lowercase the default, but will add an option to configure the name format, so users can override it themself.

[ThomDietrich]

Fixed in #77

Thanks!

[bramstroker]

Fixed in #77

Thanks!

Yes it's almost ready. Need to do some final testing and update the readme

[bramstroker]

Readme has been extended and this feature is merged into master.
Please let me know if this works for you @ThomDietrich

[bramstroker]

Configurable entity name has been implemented

[ThomDietrich]

Looks great