Too many redirects

[crichardson9]

If we take the following code:

$router->before('GET', '/.*', function() {
    if (!isset($_SESSION['user'])) {
        header('location: /login');
        exit();
    }
});

How would one stop a redirect loop when '/login' is requested?

[sigee]

@crichardson9,
Maybe there is a better way, but you can check the $_SERVER['REQUEST_URI']

$router->before('GET', '/.*', function() {
    if ($_SERVER['REQUEST_URI'] != '/login' && !isset($_SESSION['user'])) {
        header('location: /login');
        exit();
    }
});

[bramus]

In addition to @sigee's answer – which does the job just fine – you could also make use of the fact that the parts of dynamic routes can be converted to variables/parameters in the callback (see Route Patterns)

$router->before('GET', '/(.*)', function($path) {
    if ($path !== 'login' && !isset($_SESSION['user'])) {
        header('location: /login');
        exit();
    }
});

Additionally it might be a good idea to not check for equality, but to check if $path starts with login or not.