Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic demos don't work #2

Closed
dkogan opened this issue Feb 10, 2024 · 1 comment
Closed

Basic demos don't work #2

dkogan opened this issue Feb 10, 2024 · 1 comment

Comments

@dkogan
Copy link

dkogan commented Feb 10, 2024

Hello! I get issue 1!

Vanilla amd64 box running Debian/sid. I checked out the sources, then git submodule init and git submodule update and make. Then seq 5 | bin/brplot_imgui_linux_debug_gcc. It takes a few seconds to start up, and dumps a lot of debug info onto the console (both of which I'd fix; apt install feedgnuplot to see how other tools feel). Then a window comes up, but there isn't a plot. It looks like some sort of imgui demo application, or something? What exactly do you type to get the basics working?

Thanks

@branc116
Copy link
Owner

Not a bad first issue.
You are right simple stuf should just work.

First issue was that imgui layout wasn't created for you.
When developing I ignored imgui.ini file.
I fixed this problem for web a while back, by just hadcodeing the ini layout and reading it on startup, because it was anoying on web, because imgui can't save it's layout on web ( or maybe it can, I just don't know how )
I fixed it now for desktop version by just running the hardcoded layout and then reading layout from disk, so now layout is pesistent and the default one is loaded on first load.

Second problem was that default make parameter were for a debug build of brplot. Debug build is more usefull for me when developing, but when I think about it's it's easyer for me to set CONFIG=DEBUG flag every time I want to build then to make peoples lifes harder.
Debug build has quite a bit longer startup, and is ~3 times slower ( estimate. )
From now on I'll set the default CONFIG will be RELEASE.

Third problem was that when stdin closes ( seq terminates ) brplot doesn't do anything, user should pan and zoom to put the relavent part of plot into focus.
Now I added that when stdin closes, offset and zoom is set such that the whole plot is visible.
This shuld make simple things simpler.

Forth thing were submodules. It's been a pain in the ass checking out and keeping up and modifying the dependencies, and now they were pain in the ass for other people when trying to build this. I decided to just include sources of external stuff and deleted submodules.
I also deleted from those dependecies suff that was not usefull to me ( zig,cmake,notpad++, vulkan,... stuff )

Now you should just be able to write:

$ git clone https://github.com/branc116/brplot
$ cd brplot
$ make
$ seq 10 | bin/brplot_imgui_linux_release_gcc

and it's should just work.

Thanks for raising this issue, I'd never get to it on my own xD
If you find something else that is bugging you feel free to raise another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants