Invite controller also broken for iPad

[francisjervis]

Just saw this one:

Fatal Exception: NSInternalInconsistencyException
Could not load NIB in bundle: 'NSBundle </var/containers/Bundle/Application/32579E05-90AB-4C3F-9D9E-E86FE2FFCB04/TimesFree.app/BranchInvite.bundle> (not yet loaded)' with name 'BranchInviteViewController'

[aaustin]

I just added xibs for ipad specifically in this commit and updated cocoapods. I couldn't get it to crash on an iPad, but can you give the latest a try? 0324253

[francisjervis]

Looking good! Found one issue: the controller dismisses when the "done" button is tapped with the "Text" tab selected (ie sending iMessage/SMS). The app does not crash, though. This does not happen on small screens. Email functionality works works fine on all devices.

Should this release fix #49?

[aaustin]

So, it doesn't actually send SMS even when contacts are selected? Hmm and this only happens on iPad?

Somehow I missed the #49 issue. Did you test it and it worked?

[francisjervis]

Ha I found what it was - the iPad in question didn't have iMessage activated!! This causes the invite controller to dismiss silently.

Ideally I'd like to handle this differently from user-initiated cancels (ie the invitesCanceled delegate method). Arguably the SDK should alert the user in the case of failure as it does when loadContactsFromAddressBookIfPossible fails. Low priority tho!