Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android intent filter #3

Closed
josh-m-sharpe opened this issue Nov 5, 2019 · 2 comments
Closed

android intent filter #3

josh-m-sharpe opened this issue Nov 5, 2019 · 2 comments

Comments

@josh-m-sharpe
Copy link

josh-m-sharpe commented Nov 5, 2019

Hi Mike,

Excellent plugin - extremely well put together. Thanks for sharing.

Quick question. Using latest capacitor 1.3.0, my AndroidManifest.xml already has this:

<intent-filter>
  <action android:name="android.intent.action.VIEW" />
  <category android:name="android.intent.category.DEFAULT" />
  <category android:name="android.intent.category.BROWSABLE" />
  <data android:host="@string/custom_url_scheme" android:scheme="http"/>
  <data android:host="@string/custom_url_scheme" android:scheme="https"/>
</intent-filter>

That looks a lot like the intent-filter the README says to add. Do we really need a new intent filter or should the existing one be modified to include these data attributes?

<data android:scheme="https" android:host="xxxx.app.link" />
<data android:scheme="https" android:host="xxxx-alternate.app.link" />
@josh-m-sharpe
Copy link
Author

Hmm - maybe this answers my question: https://docs.branch.io/apps/android/
Yes - we need both.

What about that android:launchMode="singleTask" on <activity> - There's a callout on that page about that being required.

@josh-m-sharpe
Copy link
Author

Sorry - the singleTask intent filter is already present in a default cap project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant