Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error on Android after "Add support for App Links" commit #32

Closed
yossale opened this issue Dec 21, 2015 · 3 comments
Closed

Comments

@yossale
Copy link

yossale commented Dec 21, 2015

After the "Add support for App Links" commit (81a201a), building on Android fails due to:

private void readAndStripParam(Activity activity) {
                                   ^
  symbol:   class Activity
  location: class BranchDevice
/platforms/android/src/io/branch/BranchDevice.java:68: error: cannot find symbol
                Bundle bundle = activity.getIntent().getExtras();
                ^
  symbol:   class Bundle
  location: class BranchDevice
/platforms/android/src/io/branch/BranchDevice.java:69: error: cannot find symbol
                Set<String> extraKeys = bundle.keySet();
                ^
  symbol:   class Set
  location: class BranchDevice
@aaustin
Copy link
Contributor

aaustin commented Dec 21, 2015

@yossale This is completely my fault. I committed and synced with master this weekend while adding support for App Links but it left off a lot of the changes I had made. Can you please grab the latest? I just pushed the rest of them.

@aaustin
Copy link
Contributor

aaustin commented Dec 22, 2015

@yossale We just did a full release of 1.8.0 https://www.npmjs.com/package/branch-cordova-sdk

@aaustin aaustin closed this as completed Dec 22, 2015
@yossale
Copy link
Author

yossale commented Dec 22, 2015

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants