Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not work by default. #49

Closed
ZackMattor opened this issue Mar 1, 2016 · 4 comments
Closed

Plugin does not work by default. #49

ZackMattor opened this issue Mar 1, 2016 · 4 comments

Comments

@ZackMattor
Copy link
Contributor

You should not have to setDebug to have the plugin function. It should default to false, and have an opt in for debug. Having it fail silently isn't the best option IMO. And if this is really what you guys want it should really be called out in the docs. I can submit a PR for this after lunch if you guys want.

https://github.com/BranchMetrics/Cordova-Ionic-PhoneGap-Deferred-Deep-Linking-SDK/blob/master/www/branch.js#L52-L71

@aaustin
Copy link
Contributor

aaustin commented Mar 1, 2016

That's pretty dumb. I apologize. If you can fix it, it'd be much appreciated. Or I can toss it over to our contractors.

@ZackMattor
Copy link
Contributor Author

Do you agree that it should default to debugMode being off? I can quickly make that change.

@jestoniyap
Copy link
Contributor

There was a miscommunication on our end. The requirement for setDebug was supposed to be for the testbed app not for the actual plugin itself. We apologize for our mistake. I have removed the condition and execute the initSession once it is called.

@jestoniyap
Copy link
Contributor

@ZackMattor Please close if this was resolved. Thanks.

@aaustin aaustin closed this as completed Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants