Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Poco dependency should be lowercased #114

Open
dalamber opened this issue Jul 6, 2021 · 3 comments
Open

The Poco dependency should be lowercased #114

dalamber opened this issue Jul 6, 2021 · 3 comments

Comments

@dalamber
Copy link

dalamber commented Jul 6, 2021

Right now Branch depends on Poco/1.10.1@pocoproject/stable and links to CONAN_PKG::Poco. Also, there is a dependency on OpenSSL.
Not sure where do you get this from, but the official Conan center repository only have lowercased poco and openssl: https://conan.io/center/poco, https://conan.io/center/openssl

@dalamber
Copy link
Author

dalamber commented Jul 7, 2021

Probably, you were using the bincrafters repo (which is now deprecated). The "Poco" recipe is now also deprecated (see here and here's the "poco" package that is maintained.

My usage scenario: I have my own conan repo where I store my dependencies. I uploaded your conanfile to my own repo and used it without any problems for a while. But once I have removed the bincrafters repo (and a few others like conan-community) I no longer can compile Branch because there is no such "Poco". So I updated the recipe to depend on "poco", however, as I mentioned in my initial report, your CMakeLists.txt expects CONAN_PKG:Poco which I cannot easily change. Of course I can write a patch (or fork your project -- I actually did this for testing purposes), however, I ask you to make this change in your repo to be fully compatible with official conan repositories (i.e. depend on "poco", "openssl" -- not "Poco" and "OpenSSL".

Thanks,
Anton

@dalamber
Copy link
Author

dalamber commented Jul 7, 2021

Here's the working patch for 1.2.2 version: https://gist.github.com/dalamber/ce92ec070daee77350e0b1a71d9ab97c
It works with having only official conan repository added to the remotes:

Antons-MPB:~ antons$ conan remote list
conancenter: https://center.conan.io [Verify SSL: True]
Antons-MPB:~ antons$ 

@jdee
Copy link
Contributor

jdee commented Jul 7, 2021

Thanks for the feedback. We'll adjust the next time we cut a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants