New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store login form in state tree #53

Merged
merged 16 commits into from Feb 11, 2019

Conversation

Projects
None yet
1 participant
@brandly
Copy link
Owner

brandly commented Feb 7, 2019

eventually fixes #18

we really only support the happy path. i think this is the plan:

  • don't add to connections list until a connection has truly been established. keeping it elsewhere will allow better UI feedback
  • maintain form state so you can click away from the tab and come back. just gotta clear it when a connection is established.
  • handle on('errors'). it fires in situations like connecting to the server but your name is already taken
  • render errors in form
  • add back localStorage stuff. probably should go ahead and support a list of saved connections. wired up. needs some style.
  • add a timeout. i tried connecting to 1.1.1.1 and it hung indefinitely.

@brandly brandly force-pushed the creator-state branch from f02c188 to b07cf24 Feb 9, 2019

brandly added some commits Feb 9, 2019

@brandly brandly merged commit 4cd43f6 into master Feb 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@brandly brandly deleted the creator-state branch Feb 11, 2019

@brandly brandly referenced this pull request Feb 11, 2019

Open

saved credentials #54

1 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment