Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion disable item dislocator pinging sound #1035

Closed
wolfrunner86 opened this issue Jan 29, 2018 · 5 comments
Closed

Suggestion disable item dislocator pinging sound #1035

wolfrunner86 opened this issue Jan 29, 2018 · 5 comments

Comments

@wolfrunner86
Copy link

i would really like a way to disable the annoying pinging every time the magnet sucks something in. if there is already a way to disable this i cant find it.

@brandon3055
Copy link
Member

This will be in the next release.

@bbf
Copy link

bbf commented Feb 25, 2018

I think with you commit 4570abb, the magnet ping plays constantly, even when nothing is being picked up.

This is your new code:
if (flag || !DEConfig.disableDislocatorSound) {
I think it should be:
if (flag && !DEConfig.disableDislocatorSound) {

@kkjdroid
Copy link

I can confirm that my dislocator now plays the ping constantly.

@covers1624
Copy link
Collaborator

Brandon figured it out in smp yesterday.. 76dff8b Fix is live on curse also.

@Bunny83
Copy link

Bunny83 commented Apr 25, 2018

Funny the bugged version made it into the latest Direwolf20 pack... However great to know this so we can at least "disable" the constant pinging and get back the usual behaviour. I never found the pickup sound annoying, but it's very annoying when it plays constantly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants