Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.5.1 mangles URL with --baseurl #4

Closed
rscottbailey opened this issue Dec 11, 2019 · 1 comment · May be fixed by #5
Closed

Release 0.5.1 mangles URL with --baseurl #4

rscottbailey opened this issue Dec 11, 2019 · 1 comment · May be fixed by #5

Comments

@rscottbailey
Copy link

I think a "/" got left out somewhere... Consider this test case:

$ stick upload --bucket $REPO_BUCKET --baseurl $REPO_URL --prefix test3 dist/*
Found credentials in environment variables.
Uploading distributions to https://dssbmkth3q2xw.cloudfront.nettest3/
Downloading test3/dryice/manifest.json
Uploading test3/dryice/dryice-0.0.3-py2.py3-none-any.whl
Uploading test3/dryice/manifest.json
Uploading test3/dryice/0.0.3/json
Uploading test3/dryice/0.0.3/
Uploading test3/dryice/json
Uploading test3/dryice/
Uploading test3/dryice/dryice-0.0.3.tar.gz
Uploading test3/dryice/manifest.json
Uploading test3/dryice/0.0.3/json
Uploading test3/dryice/0.0.3/
Uploading test3/dryice/json
Uploading test3/dryice/
Looking for projects in test3/
Uploading test3/

Note the generated URL has the hostname and prefix run together. I confirmed this actually is written into the metadata also:

$ curl -u $REPO_USER:$REPO_PASS $REPO_URL/test3/
<!DOCTYPE html>
<html>
  <head>
    <title>Simple Index</title>
    <meta name="generator" content="stick/0.5.1">
  </head>
  <body>
  <a href="https://dssbmkth3q2xw.cloudfront.nettest3/dryice/">dryice</a><br>
  </body>
</html>

Naturally the content is not retrievable. :(
@rscottbailey rscottbailey mentioned this issue Dec 11, 2019
Open
@brandond
Copy link
Owner

Yeah, I added a note to the docs that you should include a trailing slash, but I guess validating it isn't a bad idea.

Fixed by 39e629f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix --baseurl handling rscottbailey/stick
2 participants
@brandond @rscottbailey