Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overly rigid #5

Open
brandondube opened this issue Aug 14, 2022 · 0 comments
Open

Overly rigid #5

brandondube opened this issue Aug 14, 2022 · 0 comments

Comments

@brandondube
Copy link
Owner

As-is, the user has to specify "beta" (or 10**beta, anyway) up-front and can't change it. That means they have to make a new EFC class, which may have some overhead. For example, we could store Vt and U and not compute them again, it is just a different S_inv = ....

Something ~=

class EFC:
   def update_beta(self, b):
        pass

would be nice to have

As well, the selection of pixels for the dark hole happens during the jacobian calculation step. Building that matrix is very costly (comparatively), so we should keep all of the pixels and move the dark hole mask into EFC or other controllers, and allow the user to change it later.

The same goes for the G -> G2 nonsense; the user shouldn't have to do it; it should go inside the EFC class' inner workings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant