Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Show algorithm under each barcode #308

Open
BoBeR182 opened this issue Jul 22, 2019 · 4 comments
Open

[Feature Request] Show algorithm under each barcode #308

BoBeR182 opened this issue Jul 22, 2019 · 4 comments

Comments

@BoBeR182
Copy link

It would be helpful to have the algorithm displayed under each barcode.

@brarcher
Copy link
Owner

brarcher commented Jan 1, 2020

Question about this request. Is the idea to have the barcode type listed when displaying the barcode (for example, when showing it at a store)? Or, is the idea to show the barcode type when creating a barcode?

I can see that showing the barcode type could be useful when creating a barcode, and even when editing a barcode (to confirm that it is the expected type). Is there a good use case for showing the barcode type when presenting a barcode at a store?

@sergiowalls
Copy link
Contributor

Totally agree with the point to show the barcode type when creating /editing the barcode.

For the second scenario, I used to work in a pub where you need to choose the barcode type when you introduce the number manually. I don't know how common is that situation but otherwise the employee should be able to identify the barcode type, although I assume that they will use always the same type.

@brarcher
Copy link
Owner

brarcher commented Jan 1, 2020

Given this, is there any opposition to having #333 add the barcode type to the following two places instead:

  1. Manually entering a barcode. Maybe something like

image

  1. Editing a card

image

(Forgive that the mockups are not using the same font as the rest of the app).

Further, as there is no driving use case for displaying the type when displaying the barcode in the LoyaltyCardViewActivity, doing so would not be included.

@sergiowalls
Copy link
Contributor

Makes sense, I will work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants