Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom resolution and FPS option #36

Closed
nulledone opened this issue Mar 4, 2018 · 6 comments
Closed

Add custom resolution and FPS option #36

nulledone opened this issue Mar 4, 2018 · 6 comments

Comments

@nulledone
Copy link

So I just saw that your app is using wrong 4K format, I thought it would be nice to report my opinions.

First of all thank you for making such a good application.

My current requests will be divided into issues so that you can easily close the ones you accomplish.

You really must remove uncommon resolutions in encoding such as 800x600 and add their corresponding xxP end of the title.

@brarcher
Copy link
Owner

brarcher commented Mar 4, 2018

I've some questions, as I do not follow some of your meaning.

So far, the resolutions which are listed are a combination of resolutions that I saw other application supporting, which are:
"176x144", "320x240", "480x360", "640x360", "640x480", "800x600", "960x720", "1024x768", "1280x720", "1920x1080", "2048x1080", "2048x858", "2560x1440", "2560x1600", "4096x2160"
as well as whatever the resolution of the source video is. Additionally, 1/2 and 1/4 the source video resolution are shown, in case the user wants to shrink the video size.

I agree that allowing a custom field for the resolution is a good step. The options presented now were a quick way to get some options available without implementing full flexibility yet.

wrong 4K format,

Do you mean that one of the resolutions which is listed is not 4K but is close, so it looks incorrect? If so, which one?

add their corresponding xxP end of the title

What do you mean by xx) at the end of the title? Can you give an example?

@nulledone
Copy link
Author

I meant xxP as 360p 720p 1080p (like the quality setting of YouTube) which I don't know the exact term also adding the picture ratio would be good (16:9, 4:3 etc)

Widely used 4k format is 3840x2160, and your app is using 4096x2160

Also I meant the resolution list is overwhelming for me.

@phuyuk
Copy link

phuyuk commented Mar 21, 2018

Arbitrary resolutions would be lovely (direct numerical entry and/or % slider), but equally/more important is preservation of the aspect ratio. Ideally, the user might also be presented with an option to pad or crop, as desired - that is, if the target aspect ratio doen't match the source. Thank you for providing the 1/2 and 1/4 scale; not only are they very convenient, but also intrinsically ensure the correct ratio. My personal preference for resolution presets would be the common standards: 1/2VGA, VGA, SVGA, XVGA, as well as the various DTV/HD resolutions. The 1/4,,1/2 presets are handy and should stay. That's my two-cents-worth. Thank you very much for the app - it's already in my 'Essental Utilities' folder.

@brarcher
Copy link
Owner

Custom resolutions was recently added (see #111). I considered adding a custom FPS option, but thought it may not be that relevant. How important is custom FPSs? Is the existing list of options insufficient? If so, re-open with details.

@nulledone
Copy link
Author

nulledone commented Jun 30, 2018

Thank you for your efforts in improving the app.

I believe custom FPS may not be necessary but as an option it would be great for special needs, also I haven't tested yet but does videos with variable FPS work great?

@brarcher
Copy link
Owner

I've only ever seen constant frames/sec. Did not know variable FPS was even a thing, but now that you mention it I see references to it.

Currently the app only supports constant FPS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants