Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app does not encode some videos. #39

Closed
shirou-jeff opened this issue Mar 4, 2018 · 12 comments
Closed

app does not encode some videos. #39

shirou-jeff opened this issue Mar 4, 2018 · 12 comments

Comments

@shirou-jeff
Copy link

Expected behavior

the user can encode any video from this app.

Actual behavior

the user can not encode any video from this app.

How to reproduce

  • Download the application.
  • Starts.
  • Try to encode some MP4 video.
  • After this, The application throws an error and stops the encoding of the desired video.
  • Browser: video transcoder V 0.4
  • Operating system:android 5.1.1

Recording Of The Bug

https://youtu.be/W3c5ir_UrPI



Posted on Utopian.io - Rewarding Open Source Contributors

@brarcher
Copy link
Owner

brarcher commented Mar 4, 2018

Watching the video, I'm a little confused. The video shows that the application successfully saved the audio of the video as an MP3. Later is started converting the video to FLV format, then reports that the encoding was canceled. The button presses are not highlighted, so it is not clear if the encoding was canceled because the "Cancel" button was pressed. Was that button pressed? If so, that is expected behavior. If not, can you reproduce with button clicks visible so it is most clear? Additionally, also include logs.

@brarcher
Copy link
Owner

brarcher commented Mar 4, 2018

An Android 5.1 the screen touches will be visible when enabling the Show Touches option under Developer Options:

image

@shirou-jeff
Copy link
Author

shirou-jeff commented Mar 4, 2018

Greetings, in answer to your question. No, the Cancel button was not pressed. The encoding was cancelled by itself, I would gladly upload a video where it shows the touches on the device screen.

Here it is, while recording the video, I touch the screen repeatedly so that I could verify the function of the bookmark.
https://youtu.be/bIUHskG3q34

@brarcher
Copy link
Owner

brarcher commented Mar 5, 2018

Interesting. Could you capture the logs when you reproduce this and attach them so I can see what is going on internally? At the top of the Developer Options there may be an option for Take Bug Report. Some of that data may be sensitive, so if you could just attach the logs around the time the app is encoding and failing, it would help me.

@shirou-jeff
Copy link
Author

Excuse me, can you explain more in detail how to do that? I'd be happy to help you. I'll do everything I can.

@brarcher
Copy link
Owner

brarcher commented Mar 6, 2018

There are a few options available for grabbing logs. The first is to connect the Android phone to a computer and use the debugging tool adb. Here is information on how to do that on Windows. Here is an alternative. Linux and Mac are similar.

If you want to capture a bug report (which contains logs and additional data) you can do so through the Developer Options menu in Android. Here are details on how to go that route.

Does that help?

@shirou-jeff
Copy link
Author

Yes, perfect. I'll do it. When I have the results I will be writing here.

@brarcher
Copy link
Owner

I was able to reproduce this myself. It appears that the mechanism I use in Android to background the processing times out and cancels the encoding:

03-19 22:21:37.734 14025 14025 D VideoTranscoder: JOB_PROGRESS_MSG: 12
03-19 22:21:37.962   595   595 I JobServiceContext: Client timed out while executing (no jobFinished received). sending onStop. fdd69cc #u0a123/1 protect.videoeditor/protect.videotranscoder.service.FFmpegProcessService
03-19 22:21:37.988 14025 14025 I VideoTranscoder: on stop job: 1
03-19 22:21:37.994 14025 14025 D VideoTranscoder: Attempt to cancel FFmpeg: success
03-19 22:21:38.019 14025 14025 D VideoTranscoder: Job complete, result: false
03-19 22:21:38.019 14025 14025 D VideoTranscoder: Encode result: false
03-19 22:21:38.191 14025 14025 I VideoTranscoder: Service destroyed

@shirou-jeff
Copy link
Author

I apologize for not reproducing the error myself. So this is something happening only on my device?

@brarcher
Copy link
Owner

If it is the same error, then no it is not only your device. I found on my Android 7 device that after 10 minutes Android will cancel the job. It may be that a number of users are encoding files which can be completed before then, so they never notice the limit.

Fixing this should be easy enough. I'll look into using a normal background service for processing instead of the job mechanism.

@brarcher
Copy link
Owner

I added a change which should resolve this. After the change I was able to successfully process a file which took over 2 hours on my phone. Before it would be canceled after 10 minutes. If the fix in the next release does not resolve your issue, please re-open.

@shirou-jeff
Copy link
Author

perfect, i will update and test the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants