Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No difference between right anchor and right separator #122

Open
antonok-edm opened this issue Aug 10, 2020 · 1 comment
Open

No difference between right anchor and right separator #122

antonok-edm opened this issue Aug 10, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@antonok-edm
Copy link
Collaborator

Currently there is no difference between trailing ^ and | characters on network rules, e.g. the parsed version fo the ||gateway.reddit.com| rule from EasyPrivacy is indistinguishable from a hypothetical ||gateway.reddit.com^ rule.

A request to https://gateway.reddit.com/example.html should be allowed by the first rule and blocked by the second. Currently both rules block this request.

@antonok-edm antonok-edm added the bug Something isn't working label Aug 10, 2020
@antonok-edm antonok-edm self-assigned this Aug 10, 2020
@antonok-edm
Copy link
Collaborator Author

The issue here stems from overloading the IS_RIGHT_ANCHOR flag to apply in both situations. There should be separate ways of indicating that the end of a filter pattern must match the end of the URL, and that the hostname from a rule contains its complete TLD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant