Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicitcancel option #141

Closed
antonok-edm opened this issue Sep 16, 2020 · 1 comment
Closed

Remove explicitcancel option #141

antonok-edm opened this issue Sep 16, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@antonok-edm
Copy link
Collaborator

Related brave-core work - brave/brave-core#6632

The Brave browser has previously returned an empty response with HTTP 200 for blocked requests, and used the $explicitcancel option to actually fail the requests. While this is a cool unique capability offered by integrating the adblocker inside a browser rather than as an extension, it actually forces more maintenance overhead because most community adblock lists are not built with this behavior in mind. Some scripts have different behavior when a particular network request is blocked rather than successful with an empty body.

We're updating Brave to always cancel the requests, just like other adblockers - which means the $explicitcancel option has no meaning and should be removed.

@antonok-edm antonok-edm added the enhancement New feature or request label Sep 16, 2020
@antonok-edm antonok-edm self-assigned this Sep 16, 2020
@antonok-edm
Copy link
Collaborator Author

Removed in 7811e54.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant