Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement cosmetic blocking [tracking] #38

Closed
antonok-edm opened this issue Jul 24, 2019 · 3 comments · Fixed by #47
Closed

Implement cosmetic blocking [tracking] #38

antonok-edm opened this issue Jul 24, 2019 · 3 comments · Fixed by #47
Assignees
@antonok-edm
Labels
enhancement New feature or request

Comments

@antonok-edm
Copy link
Collaborator

Currently, adblock-rust only deals with network filtering. There is no mechanism for parsing cosmetic rules and applying them in an efficient manner to pages as they load.
@antonok-edm antonok-edm self-assigned this Jul 24, 2019
@antonok-edm
Copy link
Collaborator Author

Current implementation work is ongoing in the cosmetic-filters branch.

This was referenced Jul 24, 2019
Closed
Closed
@antonok-edm antonok-edm added the enhancement New feature or request label Jul 24, 2019
@antonok-edm antonok-edm mentioned this issue Aug 29, 2019
Merged
@szaimen
Copy link

szaimen commented Oct 5, 2019

Any update here?

@antonok-edm
Copy link
Collaborator Author

@szaimen the current implementation for redirectable resources is being reworked to support uBlock Origin's new web_accessible_resources directory (see #50). That directly impacts cosmetic filtering, because some of those resources are scriptlets that can be injected with cosmetic filter rules. This PR should be next in line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement cosmetic filtering brave/adblock-rust
2 participants
@antonok-edm @szaimen