Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Talk intermittently spinning when on Brave #179

Closed
ShivanKaul opened this issue Feb 15, 2022 · 8 comments
Closed

Brave Talk intermittently spinning when on Brave #179

ShivanKaul opened this issue Feb 15, 2022 · 8 comments
Labels

Comments

@ShivanKaul
Copy link

ShivanKaul commented Feb 15, 2022

I can't repro this now but I've run into this twice now so figured I would file an issue and update it if it happens again.

Every now and then Brave Talk spins indefinitely for me i.e. I would go to a room and it would be stuck in a loading phase. This has happened on both Brave Nightly and Stable. Unfortunately I forgot to capture a screenshot + console log, I'll come back and update this issue if it happens again.

@fmarier mentioned that this might happen if I'm on Secure DNS + on VPN.

cc @mrose17

@mrose17 mrose17 added the P2 label Feb 15, 2022
@mrose17
Copy link
Member

mrose17 commented Feb 15, 2022

@stephendonner - has anyone ever reported this. do we have any STR? thanks!

@stephendonner
Copy link
Collaborator

@stephendonner - has anyone ever reported this. do we have any STR? thanks!

Not to my knowledge, and certainly not recently; I can try Secure DNS + VPN on Windows/Mac for a bit, later today/early tomorrow.

@mrose17
Copy link
Member

mrose17 commented Feb 15, 2022

@stephendonner - many thanks!

@fmarier
Copy link
Member

fmarier commented Feb 16, 2022

@wknapik mentioned the incompatibility between DoH and our VPN on Slack today: https://bravesoftware.slack.com/archives/C08Q08M6F/p1644939002286069

@tackley
Copy link
Collaborator

tackley commented Feb 16, 2022

@ShivanKaul do you know which spinner are you stuck on precisely? Does the screen read "Loading..." (i.e. it's attempting to validate your subscription) or "Locating Meeting Room..." (i.e. it's now trying to obtain access credentials for the room)?

Also do you by any chance have the browser console logs or network request logs? Oh, just re-read the issue, look forward to getting these next time. What I'll be looking for is which http request is blocking.

@ShivanKaul
Copy link
Author

ShivanKaul commented Feb 16, 2022

It was on the first screen, checking subscription status.

It just occurred to me that perhaps this was caused by my playing around with the Block Scripts option while testing Shields. Sure enough, if I switch on Block Scripts in Shields for talk.brave.com then I get the spinning screen.

Apologies for the noise folks, I'll close this out, I don't think it's reasonable to expect talk.brave.com to function without JS enabled and that's probably what was happening. Though I guess it might be good to detect that a user is blocking JS (given that it's a first-class option in our Shields UI) and fail softly like for e.g. Google Docs does.

@mrose17
Copy link
Member

mrose17 commented Feb 16, 2022

I've opened an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants