Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Increase Padding on Pinned Tabs #10368

Closed
jonathansampson opened this issue Aug 9, 2017 · 2 comments
Closed

Increase Padding on Pinned Tabs #10368

jonathansampson opened this issue Aug 9, 2017 · 2 comments

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Aug 9, 2017

Test plan

#10533 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Pinned tabs would benefit from better UI/UX with greater lateral padding. See this tweet by a Brave user.

If this request is implemented, we should probably consider the UI/UX of narrow tabs in general. A cursory glance at the current implementation reveals that pinned tabs, and standard narrow tabs, are displayed differently.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Desktop

  • Brave Version (revision SHA):
    N/A

  • Steps to reproduce:

    1. Create a pinned tab
  • Actual result:
    Padding is tight, at 2px.

  • Expected result:
    More lateral padding (perhaps 5px?)

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Screenshot if needed:
    (Top: Safari, Bottom: Brave)
    image

@jonathansampson jonathansampson added the design A design change, especially one which needs input from the design team. label Aug 9, 2017
@jonathansampson jonathansampson added this to the 0.21.x (Nightly Channel) milestone Aug 9, 2017
@cezaraugusto
Copy link
Contributor

+1

@NejcZdovc NejcZdovc self-assigned this Aug 9, 2017
@luixxiul luixxiul assigned luixxiul and unassigned NejcZdovc Aug 15, 2017
@NejcZdovc
Copy link
Contributor

On design call we decided to increase it from 2 to 4px

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants