Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Mute on tab's context menu should change to Unmute before switching tabs #10545

Closed
luixxiul opened this issue Aug 16, 2017 · 3 comments
Closed

Mute on tab's context menu should change to Unmute before switching tabs #10545

luixxiul opened this issue Aug 16, 2017 · 3 comments
Assignees
@bsclifton
Labels
0.19.x issue first seen in 0.19.x bug feature/context-menu feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 16, 2017 •
edited by bsclifton
Loading

Test plan

  1. Open https://www.youtube.com/watch?v=kLiLOkzLetE
  2. Mute via context menu
  3. Display the context menu again
  4. Menu should now properly show Unmute

Original issue description

Describe the issue you encountered: Mute on tab's context menu should change to Unmute before switching tabs.

Brave: 0.20.0
V8: 6.0.286.52
rev: 3e8c8dd
Muon: 4.4.7
OS Release: 16.7.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.3.5
libchromiumcontent: 60.0.3112.90

  • Steps to reproduce:

    1. Open https://www.youtube.com/watch?v=kLiLOkzLetE
    2. Mute via context menu
    3. Display the context menu again

  • Actual result: Mute is still there. After switching tabs Mute is changed to Unmute.

  • Expected result: It should have been changed to Unmute before switching the tab.

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@hferreiro hferreiro mentioned this issue Dec 21, 2017
Closed
@bsclifton bsclifton modified the milestones: Triage Backlog, 0.20.x (Beta Channel) Dec 21, 2017
@bsclifton
Copy link
Member

+1 from @TheCNixon via #11849

there was no option to umute and if I clicked mute tab again it wouldn't unmute.

@bsclifton bsclifton added the 0.20.x issue first seen in 0.20.x label Dec 21, 2017
@bsclifton
Copy link
Member

bsclifton commented Dec 22, 2017 •
edited
Loading

@NejcZdovc maybe we can recheck this after #12375 is fixed

@bsclifton bsclifton self-assigned this Jan 2, 2018
@bsclifton
Copy link
Member

bsclifton commented Jan 2, 2018 •
edited
Loading

UPDATE: confirmed this is a problem with 0.19.x also. Will start looking into this

@bsclifton bsclifton added 0.19.x issue first seen in 0.19.x and removed 0.20.x issue first seen in 0.20.x labels Jan 2, 2018
@bsclifton bsclifton mentioned this issue Jan 2, 2018
Merged
10 tasks
@NejcZdovc NejcZdovc mentioned this issue Jan 3, 2018
Closed
This was referenced Jan 9, 2018
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
0.19.x issue first seen in 0.19.x bug feature/context-menu feature/tabsbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
4 participants
@luixxiul @bsclifton @srirambv @LaurenWags