PW Manager: multiple entries for same domain, login, password

[garvankeeley]

After logging in to facebook manually a 2nd time, the prompt showed up to ask to save the PW, I agreed and ended up with 2 entries:

Expected result:

• check if PW is the same, and if so, don't prompt to save a 2nd time
• if PW not the same, ask to update the password for this domain+login

[diracdeltas]

Do the two entries have different usernames?

If the PW is not the same but the username is, it should be updating the password (but the dialog says "save" instead of "update" which may be confusing).

This is all assuming the form actions and origins are the same. If not, the password manager can't tell whether the two login forms are different.

[diracdeltas]

I think I managed to repro this; what's happening is that Facebook's login form action is different on each attempt. Ex: https://www.facebook.com/login.php?login_attempt=1&lwv=110 and https://www.facebook.com/login.php?login_attempt=1&lwv=111. i guess we can ignore the URL query params.

[garvankeeley]

confirmed fixed