Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Recover your Brave wallet dialog shown after successful recovery #13645

Closed
btlechowski opened this issue Mar 28, 2018 · 4 comments · Fixed by #13850
Closed

Recover your Brave wallet dialog shown after successful recovery #13645

btlechowski opened this issue Mar 28, 2018 · 4 comments · Fixed by #13850
Assignees
@ryanml
Labels
bug feature/rewards priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x Release 3 ...

Comments

@btlechowski
Copy link
Contributor

btlechowski commented Mar 28, 2018 •
edited by LaurenWags

Test Plan

#13850

Steps to Reproduce

  1. Clean install
  2. Create Wallet in about:preferences#payments
  3. Exit Brave
  4. Delete seed 20 and 21 in ledger-state.json
  5. Run Brave again
  6. Recover wallet with:
    vower obovoid menace tobogganist hoyle honoree pixel pestilently disconcertment sellable ruffing supervision zoroastrian based coparent slackened
  7. Click OK on the dialog
  8. Restart Brave

Actual result:
about:preferences#payments?ledgerRecoveryOverlayVisible
is opened which shows the Recover your Brave wallet dialog

Expected result:
about:preferences#payments is opened

Brave Version

Brave: 0.22.11 
V8: 6.5.254.41 
rev: 56de94731aa2aa9ab398ed928f68488f3ea5c11a 
Muon: 5.1.2 
OS Release: 6.1.7601 
Update Channel: Release 
OS Architecture: x64 
OS Platform: Microsoft Windows 
Node.js: 7.9.0 
Brave Sync: v1.4.2 
libchromiumcontent: 65.0.3325.181

cc @LaurenWags @kjozwiak @bsclifton @NejcZdovc
@btlechowski btlechowski added this to the 0.22.x (Beta Channel) milestone Mar 28, 2018
@bsclifton bsclifton mentioned this issue Mar 29, 2018
Closed
10 tasks
@bsclifton bsclifton added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Mar 29, 2018
@bsclifton bsclifton modified the milestones: 0.22.x (Beta Channel), Backlog (Prioritized) Mar 29, 2018
@bsclifton
Copy link
Member

kicked this out of the 0.22.x milestone- a fix would be nice... but I don't think it's required for this release (work-around is easy- user can just close the tab)

@NejcZdovc NejcZdovc assigned ryanml and unassigned NejcZdovc Apr 17, 2018
@ryanml ryanml mentioned this issue Apr 17, 2018
Merged
10 tasks
@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), 0.22.x Release 3 (Beta channel) Apr 19, 2018
This was referenced May 3, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

Blocked on #14001 - Unable to test without the corrupted seed overlay

This was referenced May 8, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented May 8, 2018 •
edited by btlechowski

Verified with macOS 10.12.6 using

  • 0.22.703 903b8d0
  • muon 6.0.8
  • libchromiumcontent 66.0.3359.139

Verified on Windows x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Verified on Ubuntu 17.10 x64

  • 0.22.706 e11b027
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.9

@srirambv srirambv mentioned this issue May 8, 2018
Closed
@srirambv
Copy link
Collaborator

srirambv commented May 8, 2018

Functionality works but needs to verify once #14063 is confirmed

@kjozwiak kjozwiak mentioned this issue May 10, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanml ryanml

Labels
bug feature/rewards priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
6 participants
@bsclifton @ryanml @NejcZdovc @srirambv @LaurenWags @btlechowski