Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Use API: app.dock.downloadFinished(filePath) #1667

Closed
bbondy opened this issue May 11, 2016 · 2 comments
Closed

Use API: app.dock.downloadFinished(filePath) #1667

bbondy opened this issue May 11, 2016 · 2 comments
Assignees
@cndouglas
Labels
OS/macOS QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include shell-integration Integrating brave with OS-level UI features.
Milestone
0.15.300 (Frozen,...

Comments

@bbondy
Copy link
Member

bbondy commented May 11, 2016 •
edited by luixxiul

Test plan

#8418 (comment)

Should be added in next release after 0.37.8
electron/electron#5477
@bbondy bbondy changed the title Add API: app.dock.downloadFinished(filePath) Use API: app.dock.downloadFinished(filePath) May 11, 2016
@cndouglas cndouglas added OS/macOS shell-integration Integrating brave with OS-level UI features. labels Dec 9, 2016
@cndouglas cndouglas mentioned this issue Jan 11, 2017
Closed
@luixxiul luixxiul added this to the Backlog milestone Jan 11, 2017
@cndouglas cndouglas self-assigned this Apr 21, 2017
@cndouglas cndouglas mentioned this issue Apr 21, 2017
Merged
4 tasks
@cndouglas cndouglas modified the milestones: 0.15.1, Backlog Apr 21, 2017
@cndouglas
Copy link

Q/A steps:

  1. Navigate to https://brave.com/ .
  2. Click Get Brave and then click Save.
  3. As the download progress bar approaches 100%, look at the Downloads folder dock icon.
  4. Make sure the dock icon "bounces" when the download finishes.

This was referenced May 2, 2017
Closed
Closed
Closed
Closed
Closed
Closed
@alexwykoff
Copy link
Contributor

Not seeing dock bounce in 0.15.307, was this reverted?

This was referenced May 25, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cndouglas cndouglas

Labels
OS/macOS QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include shell-integration Integrating brave with OS-level UI features.
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
5 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @cndouglas