This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
remove mutation observers from brave content scripts #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't add duplicate submit and click event listeners on every password check only check for changes while page is visible
|
++ and no more mutation observers for the future. |
| @@ -3,7 +3,7 @@ | |||
| * You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| if (chrome.contentSettings.passwordManager == 'allow') { | |||
|
|
|||
| let credentials = {} | |||
There was a problem hiding this comment.
tryAutofillForm no longer needs credentials as an argument
This was referenced Sep 14, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan:
Check password capture on submit
Check password fill for both immediate and delayed load password forms
don't add duplicate submit and click event listeners on every password check
only check for changes while page is visible
cc @bbondy @diracdeltas