Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Escape key not closing add funds dialog #3800

Closed
jkup opened this issue Sep 7, 2016 · 3 comments · Fixed by #13884
Closed

Escape key not closing add funds dialog #3800

jkup opened this issue Sep 7, 2016 · 3 comments · Fixed by #13884

Comments

@jkup
Copy link
Contributor

jkup commented Sep 7, 2016

Did you search for similar issues before submitting this one?
Searched for "esc"

Describe the issue you encountered:
Once you open the "Add funds..." dialog on the Payments page you can't close it using just the keyboard. This affects Accessibility and general UI/UX. I see that the dialog component has a listener for it so I'm assuming something else is catching that keyboard event.

Expected behavior:

Hitting escape should close a dialog modal.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS
  • Brave Version:
    0.12.0
  • Steps to reproduce:
    1. Go to preferences > payments
    2. Click on "Add Funds..."
    3. Hit the escape key
  • Screenshot if needed:
  • Any related issues:
@jkup jkup self-assigned this Dec 16, 2016
@jkup jkup added this to the 0.13.2 milestone Dec 16, 2016
@bsclifton bsclifton modified the milestones: 0.13.1, 0.13.2 Jan 23, 2017
@bsclifton
Copy link
Member

This was attempted with #6248 but had some issues (milestone removed).

If you wanted to try the patch from that PR, you can grab it here:
https://patch-diff.githubusercontent.com/raw/brave/browser-laptop/pull/6248.patch

@mrose17 mrose17 added this to the 1.0.1 milestone Mar 7, 2017
@ghost ghost added the bug label Sep 26, 2017
@ghost ghost removed this from the 1.0.1 milestone Sep 26, 2017
@ghost
Copy link

ghost commented Sep 26, 2017

To retest after refactor of #11037

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@NejcZdovc NejcZdovc added the needs-discussion A suggestion that lacks agreement from the team. label Apr 9, 2018
@jasonrsadler jasonrsadler self-assigned this Apr 11, 2018
@jasonrsadler jasonrsadler added PR/pending-review and removed needs-discussion A suggestion that lacks agreement from the team. labels Apr 24, 2018
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.22.x Release 3 (Beta channel) Apr 26, 2018
@srirambv
Copy link
Collaborator

srirambv commented May 2, 2018

Verified on Windows x64

  • 0.22.700 9306021
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.7

Verified on macOS 10.13.3 x64 using the following build:

  • 0.22.706 e11b027
  • libchromiumcontent: 66.0.3359.139
  • muon: 6.0.9

Verified on Ubuntu 17.10 x64

  • 0.22.706 e11b027
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.