Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

added release notes for 0.12.1 #3941

Merged
merged 5 commits into from
Sep 13, 2016
Merged

added release notes for 0.12.1 #3941

merged 5 commits into from
Sep 13, 2016

Conversation

alexwykoff
Copy link
Contributor

First pass at release notes for 0.12.1

@alexwykoff alexwykoff added this to the 0.12.1dev milestone Sep 13, 2016
@@ -1,7 +1,30 @@
# Changelog

## [0.12.1](https://github.com/brave/browser-laptop/releases/v0.12.1dev)
- (todo)
- Added Malay (Malaysia) language. ([#3843](https://github.com/brave/browser-laptop/issues/3843))
- Added extensions. ([#3926](https://github.com/brave/browser-laptop/issues/3926))([#3867](https://github.com/brave/browser-laptop/issues/3867))([#2224](https://github.com/brave/browser-laptop/issues/2224))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is misleading and makes the reader think we have new extensions that are added, which is not the case, if it was we woul say which ones.
The first one is an about:extensions page
The last 2 are the same but should be more description, something like Added support for extension action buttons for password managers.

I'd put the Malay language at the bottom of the added list since it isn't applicable to everyone.

@luixxiul
Copy link
Contributor

@alexwykoff Is it okay that all strings after https://*.slack.com/home are italic?

@bbondy
Copy link
Member

bbondy commented Sep 13, 2016

Yes seems like a markdown mistake, pls fix that as well @alexwykoff

@@ -1,7 +1,30 @@
# Changelog

## [0.12.1](https://github.com/brave/browser-laptop/releases/v0.12.1dev)
- (todo)
- Added about:extensions page. ([#3926](https://github.com/brave/browser-laptop/issues/3926))
- Added support for extension action buttons for password managers. ([#3867](https://github.com/brave/browser-laptop/issues/3867))([#2224](https://github.com/brave/browser-laptop/issues/2224))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one before about:extensions page

@bbondy
Copy link
Member

bbondy commented Sep 13, 2016

Nice, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants