Regression: Pins without favicons are nearly invisible and indistinguishable from one another

[alexwykoff]

Did you search for similar issues before submitting this one?
Yes, this appears to be a regression

Describe the issue you encountered:
When pinning a page without a favicon the pin provided is a very close tint of the tab tray (which appears to be a shade, but it's all grey anyways). The pins are not distinguishable so it is confusing to the user as to which pin will show them the content they are looking for.

Expected behavior:
Pins for pages without favicons should have some unique means of identifying their contents to the user.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Tested on Win7 x64
• Brave Version:
  0.12.3 RC5
• Steps to reproduce:
  1. Visit pages without favicons (ex : alexwykoff.com , about:autofill, etc)
  2. Pin those pages
  3. Try to remember which pin leads to the site you want to visit
• Screenshot if needed:
  
• Any related issues:
  If page dont have favicon pin page icon is invisible. #1260
  pinned tabs are invisible if they don't have a favicon #1894

[alexwykoff]

@bradleyrichter I put this on 1.1 for the interest of keeping our burden light, if you have a simple solution, feel free to bump it up :)

[bradleyrichter]

when was it working?

[alexwykoff]

#1895 "fixes #1894"

I'm not sure if there was any OTR conversations about the design implications, but had assumed the fix would have been more robust than 'make it another grey'. :)

[bradleyrichter]

the fix would be:

if favicon = nada, then
show default page icon instead (http://fontawesome.io/icon/file-o/)

; )

[cezaraugusto]

for now we have the default paper icon for when tabs have no favicons so seems to be fixed. Closing pls re-open if I'm mistaken