Skip to content
This repository has been archived by the owner. It is now read-only.

Add Reader view for pages #517

Closed
bbondy opened this Issue Feb 1, 2016 · 29 comments

Comments

Projects
None yet
@bbondy
Copy link
Member

bbondy commented Feb 1, 2016

Maybe use this: https://github.com/mozilla/readability for reading view
Might be useful for an offline mode too and for indexing pages for better autocomplete results.

@alexwykoff

This comment has been minimized.

Copy link
Member

alexwykoff commented Oct 4, 2016

+1 from support

@alexwykoff

This comment has been minimized.

Copy link
Member

alexwykoff commented Oct 28, 2016

@Liunkae Liunkae added the parity label Nov 19, 2016

@luixxiul luixxiul added this to the Backlog milestone Jan 7, 2017

@thechild

This comment has been minimized.

Copy link

thechild commented Apr 6, 2017

One other option would be to just include this chrome extension (https://mercury.postlight.com/reader/) to get a great reader view.

@LaurenWags

This comment has been minimized.

@eljuno

This comment has been minimized.

Copy link
Contributor

eljuno commented Jul 8, 2017

@eljuno

This comment has been minimized.

Copy link
Contributor

eljuno commented Jul 20, 2017

@rdetert

This comment has been minimized.

Copy link

rdetert commented Aug 9, 2017

+1 Reader Mode is the one thing I miss from Safari on desktop. I can read so much faster.

@calebbarr

This comment has been minimized.

Copy link

calebbarr commented Aug 21, 2017

+1

@srirambv

This comment has been minimized.

Copy link
Collaborator

srirambv commented Sep 5, 2017

@ironfish

This comment has been minimized.

Copy link

ironfish commented Sep 14, 2017

+100

@stephenkilpatrick

This comment has been minimized.

Copy link

stephenkilpatrick commented Sep 15, 2017

Add me to the +1's.

@davidhfo

This comment has been minimized.

Copy link

davidhfo commented Sep 30, 2017

Another +1.

@iamhenry

This comment has been minimized.

Copy link

iamhenry commented Oct 12, 2017

Looks like this isn't a priority but I'm going to +1 this as well.

@jonathansampson

This comment has been minimized.

Copy link
Collaborator

jonathansampson commented Oct 13, 2017

After testing Mercury Reader, I found that Brave has pretty good OOB support. I'm going to create a master issue to track any needed APIs, and progress towards supporting this as a Reader option in future builds: https://chrome.google.com/webstore/detail/mercury-reader/oknpjjbmpnndlpmnhmekjpocelpnlfdi

@bbondy bbondy removed this from the Backlog milestone Oct 19, 2017

@bsclifton bsclifton removed the enhancement label Nov 22, 2017

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017

@patertmg

This comment has been minimized.

Copy link

patertmg commented Dec 10, 2017

Got #Mercury Reader Extension (but not #Evernote Extension) to work following this article: https://medium.com/@jonathansampson/testing-chrome-extensions-in-brave-8e25d1f7386d

@eljuno

This comment has been minimized.

Copy link
Contributor

eljuno commented Dec 15, 2017

@blacktop

This comment has been minimized.

Copy link

blacktop commented Dec 17, 2017

+1

@jonathansampson

This comment has been minimized.

Copy link
Collaborator

jonathansampson commented Dec 20, 2017

@patertmg How was the Mercury Reader experience?

@patertmg

This comment has been minimized.

Copy link

patertmg commented Dec 20, 2017

@jonathansampson Great so long! There are only two minor concerns: (1) don’t know why, but Mercury doesn’t show an icon - there’s only a grey space up in the corner, so I have to click “blindly” on it (2) would be even better if i could define a shortcut to start Mercury. Thanks!

@Jacalz

This comment has been minimized.

Copy link
Collaborator

Jacalz commented Feb 4, 2018

The thing is that it would be better to have an open sourced reader mode integrated in to the browser than having a closed source reader mode extension. Mercury reader is good but since Brave is a browser that cares about privacy, maby it should be better to use mozilla readability instead 👍 Then we can truly know that the sites you are visiting doesn't get leaked 😅

@oleim

This comment has been minimized.

Copy link

oleim commented Feb 12, 2018

+1 (Using Brave as default and this is the only feature I miss.)

@jonathansampson

This comment has been minimized.

Copy link
Collaborator

jonathansampson commented Feb 13, 2018

Just ran through another test with Mercury; I noticed only the same issue(s) that @patertmg reported (missing browserAction icon). Here's the logic which shows the browserAction icon:

if (basePath19 && basePath38) {
return `-webkit-image-set(
url(${basePath}/${basePath19}) 1x,
url(${basePath}/${basePath38}) 2x`
}

Note that Mercury doesn't provide 16 or 38 pixel icons:

   "icons": {
      "128": "img/icon-128.png",
      "16": "img/icon-16.png",
      "48": "img/icon-48.png"
   },

@bbondy, what are your thoughts here? Would https://github.com/mozilla/readability be a better route to take, rather than something like Mercury?

@srirambv

This comment has been minimized.

Copy link
Collaborator

srirambv commented May 1, 2018

@LaurenWags

This comment has been minimized.

Copy link

LaurenWags commented May 2, 2018

+1 from customer email

@skotzko

This comment has been minimized.

Copy link

skotzko commented Jun 15, 2018

+1

@mbabco

This comment has been minimized.

Copy link

mbabco commented Jun 19, 2018

Add me to the list of folks who would love a readability feature.

@okiess

This comment has been minimized.

Copy link

okiess commented Jun 28, 2018

+1

@bigt2000

This comment has been minimized.

Copy link

bigt2000 commented Jun 30, 2018

I also would love this option. It is one of my favorite built in features in Firefox and Vivaldi. Honestly I really love Brave. I am just waiting for more of these features and add on support to show up before it will be perfect.

@bsclifton

This comment has been minimized.

Copy link
Member

bsclifton commented Aug 2, 2018

Unfortunately, we won't be able to address this with browser-laptop... but we should with Brave Core (even if just by having an extension available)

Closing in favor of brave/brave-browser#679

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.