Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add Reader view for pages #517

Closed
bbondy opened this issue Feb 1, 2016 · 29 comments
Closed

Add Reader view for pages #517

bbondy opened this issue Feb 1, 2016 · 29 comments
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. parity Features which should be supported in Brave since they're supported in other major browsers. wontfix

Comments

@bbondy
Copy link
Member

bbondy commented Feb 1, 2016

Maybe use this: https://github.com/mozilla/readability for reading view
Might be useful for an offline mode too and for indexing pages for better autocomplete results.

@alexwykoff
Copy link
Contributor

+1 from support

@alexwykoff
Copy link
Contributor

+1 from support : https://linkbubble.zendesk.com/agent/tickets/6311

@cndouglas cndouglas added the parity Features which should be supported in Brave since they're supported in other major browsers. label Nov 19, 2016
@luixxiul luixxiul added this to the Backlog milestone Jan 7, 2017
@thechild
Copy link

thechild commented Apr 6, 2017

One other option would be to just include this chrome extension (https://mercury.postlight.com/reader/) to get a great reader view.

@LaurenWags
Copy link
Member

@eljuno
Copy link
Contributor

eljuno commented Jul 8, 2017

+1 from community

@eljuno
Copy link
Contributor

eljuno commented Jul 20, 2017

+1 from community

@rdetert
Copy link

rdetert commented Aug 9, 2017

+1 Reader Mode is the one thing I miss from Safari on desktop. I can read so much faster.

@calebbarr
Copy link

+1

@srirambv
Copy link
Collaborator

srirambv commented Sep 5, 2017

@ironfish
Copy link

+100

@stephenkilpatrick
Copy link

Add me to the +1's.

@davidhfo
Copy link

Another +1.

@iamhenry
Copy link

Looks like this isn't a priority but I'm going to +1 this as well.

@jonathansampson
Copy link
Collaborator

After testing Mercury Reader, I found that Brave has pretty good OOB support. I'm going to create a master issue to track any needed APIs, and progress towards supporting this as a Reader option in future builds: https://chrome.google.com/webstore/detail/mercury-reader/oknpjjbmpnndlpmnhmekjpocelpnlfdi

@bbondy bbondy removed this from the Backlog milestone Oct 19, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@patertmg
Copy link

Got #Mercury Reader Extension (but not #Evernote Extension) to work following this article: https://medium.com/@jonathansampson/testing-chrome-extensions-in-brave-8e25d1f7386d

@eljuno
Copy link
Contributor

eljuno commented Dec 15, 2017

@blacktop
Copy link

+1

@jonathansampson
Copy link
Collaborator

@patertmg How was the Mercury Reader experience?

@patertmg
Copy link

@jonathansampson Great so long! There are only two minor concerns: (1) don’t know why, but Mercury doesn’t show an icon - there’s only a grey space up in the corner, so I have to click “blindly” on it (2) would be even better if i could define a shortcut to start Mercury. Thanks!

@Jacalz
Copy link
Contributor

Jacalz commented Feb 4, 2018

The thing is that it would be better to have an open sourced reader mode integrated in to the browser than having a closed source reader mode extension. Mercury reader is good but since Brave is a browser that cares about privacy, maby it should be better to use mozilla readability instead 👍 Then we can truly know that the sites you are visiting doesn't get leaked 😅

@oleim
Copy link

oleim commented Feb 12, 2018

+1 (Using Brave as default and this is the only feature I miss.)

@jonathansampson
Copy link
Collaborator

jonathansampson commented Feb 13, 2018

Just ran through another test with Mercury; I noticed only the same issue(s) that @patertmg reported (missing browserAction icon). Here's the logic which shows the browserAction icon:

if (basePath19 && basePath38) {
return `-webkit-image-set(
url(${basePath}/${basePath19}) 1x,
url(${basePath}/${basePath38}) 2x`
}

Note that Mercury doesn't provide 16 or 38 pixel icons:

   "icons": {
      "128": "img/icon-128.png",
      "16": "img/icon-16.png",
      "48": "img/icon-48.png"
   },

@bbondy, what are your thoughts here? Would https://github.com/mozilla/readability be a better route to take, rather than something like Mercury?

@srirambv
Copy link
Collaborator

srirambv commented May 1, 2018

@LaurenWags
Copy link
Member

+1 from customer email

@skotzko
Copy link

skotzko commented Jun 15, 2018

+1

@mbabco
Copy link

mbabco commented Jun 19, 2018

Add me to the list of folks who would love a readability feature.

@okiess
Copy link

okiess commented Jun 28, 2018

+1

@bigt2000
Copy link

I also would love this option. It is one of my favorite built in features in Firefox and Vivaldi. Honestly I really love Brave. I am just waiting for more of these features and add on support to show up before it will be perfect.

@bsclifton
Copy link
Member

Unfortunately, we won't be able to address this with browser-laptop... but we should with Brave Core (even if just by having an extension available)

Closing in favor of brave/brave-browser#679

@bsclifton bsclifton added wontfix addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. labels Aug 2, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. parity Features which should be supported in Brave since they're supported in other major browsers. wontfix
Projects
None yet
Development

No branches or pull requests