Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"login with google" doesn't log you in #57

Closed
bridiver opened this issue Dec 16, 2015 · 8 comments · Fixed by #145
Closed

"login with google" doesn't log you in #57

bridiver opened this issue Dec 16, 2015 · 8 comments · Fixed by #145
Assignees

Comments

@bridiver
Copy link
Collaborator

Login to Feedly.com using google never actually logs me in. I can access mail.google.com after the authentication through the feedly sign-on page, but I can't access Feedly itself. I haven't tried other sites that use google login

@bbondy
Copy link
Member

bbondy commented Dec 16, 2015

we're probably adblocking too much, there's a fix I need to do there about properly detecting third party hosts. Don't spend time investigating this since it's probably related.

@bridiver
Copy link
Collaborator Author

I didn't see anything being blocked

@bbondy
Copy link
Member

bbondy commented Dec 16, 2015

pls try with updating package.json with the stock electron-prebuilt to see if it works.

@diracdeltas
Copy link
Member

I noticed this yesterday on asana.com too

@bbondy
Copy link
Member

bbondy commented Dec 16, 2015

ya after seeing the problem I don't think it's related to adblock.

@diracdeltas
Copy link
Member

confirmed that it doesn't work with stock electron-prebuilt either

login with facebook on spotify.com works though

@bbondy
Copy link
Member

bbondy commented Dec 16, 2015

thanks for verifying

@bridiver
Copy link
Collaborator Author

it looks like the problem is window.opener. There are some hints on how we might work around it here:
electron/electron#1865

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants