Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Translate Bookmarks Manager #7130

Closed
NejcZdovc opened this issue Feb 8, 2017 · 6 comments
Closed

Translate Bookmarks Manager #7130

NejcZdovc opened this issue Feb 8, 2017 · 6 comments

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 8, 2017

Test plan

If translations come in soon:

  • change browser language
  • open bookmark manager
  • verify title and last visited are translated

otherwise, no testing needed

original issue text

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Title and Last visited in Bookmarks Manager are not translated.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    f7a5e17

  • Steps to reproduce:

    1. Go to Bookmarks Manager
    2. Check out Title and Last visited
    3. Go to Preferences -> General
    4. Change language
    5. Go back to Bookmarks Manager
    6. Title and Last visited are still in english
  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

@NejcZdovc NejcZdovc added this to the contributor backlog milestone Feb 8, 2017
@NejcZdovc
Copy link
Contributor Author

@cndouglas
Copy link

PR: #7139

@cndouglas cndouglas modified the milestones: 0.13.4, contributor backlog Feb 8, 2017
@bsclifton bsclifton modified the milestones: 0.13.3, 0.13.4 Feb 9, 2017
@cndouglas
Copy link

@luixxiul This is a very minor change. I don't think we need QA for this (we can't even realistically verify until the texts are translated and imported), and I don't think it needs to be included in the release notes.

@luixxiul
Copy link
Contributor

I could verify change by myself by doing l10n on Transifex so no worry

@luixxiul
Copy link
Contributor

luixxiul commented Feb 11, 2017

Also the issue can be named "more l10n done" etc on release notes if it is worth mentioning. At least this does not have to be excluded from the release note so Iabelled to include it

@cndouglas
Copy link

cndouglas commented Feb 11, 2017

Fair enough. If/when we import the translations from Transifex, we can use Spanish to test (I just translated it there).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants