Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pocket extension on Windows ia32 is always red #7357

Closed
srirambv opened this issue Feb 23, 2017 · 12 comments
Closed

Pocket extension on Windows ia32 is always red #7357

srirambv opened this issue Feb 23, 2017 · 12 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 23, 2017

Test plan

  1. Enable Pocket
  2. Save a page to Pocket
  3. Make sure the icon becomes red

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Pocket extension on Windows i32 is always red

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 7 ia32

  • Brave Version (revision SHA):
    Brave 0.13.4
    rev 71d8ffc

  • Steps to reproduce:

    1. Enable Pocket on a clean install of 0.13.5 preview 2
    2. After pocket widget is shown is it is always red
    3. Open any about:pages still shows red
  • Actual result:
    Shows red icon after enabled

  • Expected result:
    Should not show the red icon, should show red icon only when a page is saved

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@srirambv srirambv added this to the 0.13.5 milestone Feb 23, 2017
@bbondy bbondy modified the milestones: 0.13.6, 0.13.5 Feb 25, 2017
@bsclifton
Copy link
Member

was this fixed with #7437?
cc: @alexwykoff

@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 14, 2017
@bsclifton
Copy link
Member

@srirambv @alexwykoff can we retest this one? if it's still an issue, maybe we can push to 0.14.3. Thanks 😄

@srirambv
Copy link
Collaborator Author

srirambv commented Apr 5, 2017

Its quite the opposite now on ia32. It doesn't show the widget in red even after saving a page. Shows the save message only for the first link saved but not the second one.
8087

@bsclifton
Copy link
Member

Moving to 0.14.3

@bsclifton bsclifton modified the milestones: 0.14.3, 0.14.2 Apr 7, 2017
@bsclifton bsclifton added the needs-owner ♞ This issue is tagged for an upcoming release but has no owner. label Apr 7, 2017
@alexwykoff alexwykoff changed the title Pocket extension on Windows i32 is always red Pocket extension on Windows ia32 is always red Apr 18, 2017
@alexwykoff
Copy link
Contributor

This is expected behavior. We shouldn't show a red pocket.

@alexwykoff alexwykoff removed this from the 0.15.1 milestone Apr 18, 2017
@luixxiul
Copy link
Contributor

I think it is somewhat confusing... since other icons around the pocket one change color based on status. LastPass changes the color into yellow when the extension has a warning notification. Shield button changes its color too.

I don't see the reason to disable color change on Pocket.

@luixxiul luixxiul added needs-info Another team member needs information from the PR/issue opener. and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels May 29, 2017
@luixxiul
Copy link
Contributor

screenshot 2017-05-29 17 14 26 screenshot 2017-05-29 17 14 48

@bsclifton
Copy link
Member

@luixxiul do you have a way to test in Chrome using a 32 bit Windows VM? I am curious if Chrome has the same issue

@luixxiul
Copy link
Contributor

luixxiul commented Jun 9, 2017

ok I'll give a try.

@luixxiul luixxiul removed needs-info Another team member needs information from the PR/issue opener. invalid labels Jun 19, 2017
@luixxiul
Copy link
Contributor

The pocket icon seems to have the color based on the status. See: #9157 (comment).

@srirambv would you check the icon again with a fresh profile? if it is confirmed that the bug has been fixed, please re-close the issue. Thanks!

@luixxiul luixxiul reopened this Jun 19, 2017
@srirambv
Copy link
Collaborator Author

Doesn't seem to be an issue for Windows ia32. Pocket icon becomes grey when navigated to a unmarked page and shows red when opened

Closing the issue for now

cc: @luixxiul

@LaurenWags
Copy link
Member

confirmed pocket icon is not always red on MacOS after pocket is enabled. however, cannot confirm it becomes red due to #9669

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.