Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Please add a notifier when a background tab gets a notification or a JS alert, like Firefox #9861

Open
echosa opened this issue Jul 4, 2017 · 2 comments

Comments

@echosa
Copy link
Contributor

echosa commented Jul 4, 2017

  • Did you search for similar issues before submitting this one?

Yes

  • Describe the issue you encountered:

In Firefox, if something changes in a background tab, FF puts a dot on the tab (see screenshot) to notify the user that something has changed. Brave does not do this, but it'd be great if it did. This is very useful.

This should work with normal and pinned tabs.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

macOS 10.12.5

  • Brave Version (revision SHA):

0.17.13 (f7242c7)

  • Steps to reproduce:

    1. Open a website that will change in a tab. (A web mail client should work.)
    2. Cause the background tab to change content. (Send an email that will be received in the tab.)
  • Actual result:

The tab doesn't change.

  • Expected result:

The tab should show an indicator that its content changes, like Firefox.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes

  • Is this an issue in the currently released version?

Yes

  • Can this issue be consistently reproduced?

Yes

  • Screenshot if needed:

Here's what this looks like in Firefox. This is a pinned Fastmail tab in Firefox's built-in compact dark theme. The first screenshot shows the tab before the tab content changed, and the second screenshot is after. Notice the light blue indicator in the second screenshot.

screen shot 2017-07-04 at 9 37 11 am

screen shot 2017-07-04 at 2 38 38 am

@cndouglas
Copy link

I think the blue dot is shown if the inactive tab 1) receives a notification or 2) presents a JavaScript alert.

@echosa
Copy link
Contributor Author

echosa commented Jul 9, 2017

@liunkae Sounds about right. Good enough for me.

@echosa echosa changed the title Please add a notifier when a background tab changes Please add a notifier when a background tab gets a notification or a JS alert, like Firefox Jul 9, 2017
@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants