Registering a custom protocol handler crashes

[Mossop]

• Electron version: 1.4.0
• Operating system: Windows

In Tofino we register a tofino:// protocol handler through the protocol.registerHttpProtocol electron API. This works in regular Electron but crashes with a segmentation fault in current builds of brave/electron.

[bridiver]

which brave electron version? It may be this
082272d

[bridiver]

it broke after electron/electron@e5daf63
and was fixed in the commit above

[Mossop]

I just retested with current master, v1.4.8 and still see the issue. I've been trying to bisect but it looks like you rebase for each new Electron version which makes bisecting more difficult.

[bridiver]

Interesting. We also register custom protocol handlers, but we're using navigator.registerProtocolHandler so I guess it's possible that the electron api still has a problem with our changes

[bridiver]

on the rebase issue, we have been the only people using our fork so far afaik and rebasing made things easier for us, but we're trying to move our changes from atom -> brave and upstream some changes to make it easier to extend